Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CPU offload for DDP/single-gpu #3242

Merged

Conversation

mvpatel2000
Copy link
Contributor

What does this PR do?

Remove CPU offload for DDP/single-gpu. With the unified API, we added this in, but it is not needed / does not exist in prior versions. This really slows down GPU tests.

Copy link
Contributor

@snarayan21 snarayan21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick lgtm

@mvpatel2000 mvpatel2000 merged commit b2edfbe into mosaicml:dev May 1, 2024
15 checks passed
@mvpatel2000 mvpatel2000 deleted the mvpatel2000/accelerate-tests-v2 branch May 1, 2024 17:44
j316chuck pushed a commit that referenced this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants