load_checkpoint defaults to strict weight match #3219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakinggg
approved these changes
Apr 29, 2024
|
I'm worried this breaks BC |
It is an API behavior change, but I view it as a fix which I think is sufficient. See linked github issue for motivation |
mvpatel2000
force-pushed
the
mvpatel2000/fix-load-default
branch
from
bc02f7b
to
ef71a2b
Compare
b-chu
approved these changes
Apr 29, 2024
j316chuck
pushed a commit
that referenced
this pull request
May 16, 2024
Co-authored-by: Daniel King <43149077+dakinggg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Trainer has an argument
load_strict_model_weightswhich defaults toTrue. However, the same argument inload_checkpointdefaults toFalse, whereas it should be consistent with the Trainer argument.