Fixing error condition check when device microbatch size times seq parallelism dim is not 1 due to floating point precision #3200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h_size_seq_parallelism
…_parallelism' of github.com:mosaicml/composer into shashank/fix_error_condition_device_microbatch_size_seq_parallelism
…h_size_seq_parallelism
mvpatel2000
approved these changes
Apr 19, 2024
ShashankMosaicML
deleted the
shashank/fix_error_condition_device_microbatch_size_seq_parallelism
branch
DhruvDh
pushed a commit
to DhruvDh/composer
that referenced
this pull request
Apr 21, 2024
…rallelism dim is not 1 due to floating point precision (mosaicml#3200) * .. * .. * lint
j316chuck
pushed a commit
that referenced
this pull request
May 16, 2024
…rallelism dim is not 1 due to floating point precision (#3200) * .. * .. * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Due to floating point precision, if the device microbatch size times the sequence parallel dimension is not exactly 1, then this error condition is triggered. This PR allows for some error due to floating point precision.