Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jiggling tests and adding gc collect #2312

Merged
merged 2 commits into from
Jun 17, 2023
Merged

Jiggling tests and adding gc collect #2312

merged 2 commits into from
Jun 17, 2023

Conversation

bcui19
Copy link
Contributor

@bcui19 bcui19 commented Jun 16, 2023 •
edited
Loading

What does this PR do?

Adds gc to pytest fixture + jiggles tests s.t. daily passes?

https://github.com/mosaicml/composer/actions/runs/5293961521

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@bcui19 bcui19 requested a review from mvpatel2000 June 16, 2023 21:07
@bcui19 bcui19 marked this pull request as ready for review June 16, 2023 21:08
mvpatel2000
mvpatel2000 approved these changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hero

tests/fixtures/autouse_fixtures.py Outdated Show resolved Hide resolved
@bcui19 @mvpatel2000
Update tests/fixtures/autouse_fixtures.py
fef0f26 
Co-authored-by: Mihir Patel <mihir.v.patel7@gmail.com>
@bcui19 bcui19 enabled auto-merge (squash) June 16, 2023 21:39
@bcui19 bcui19 disabled auto-merge June 17, 2023 02:02
@mvpatel2000 mvpatel2000 merged commit 4904732 into mosaicml:dev Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvpatel2000 mvpatel2000 mvpatel2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bcui19 @mvpatel2000