Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed how save_checkpoint_to_save_folder called CheckpointSaver object to save state and logger #2300

Merged
merged 2 commits into from
Jun 12, 2023
Merged

Fixed how save_checkpoint_to_save_folder called CheckpointSaver object to save state and logger #2300

merged 2 commits into from
Jun 12, 2023

Conversation

KuuCi
Copy link
Contributor

@KuuCi KuuCi commented Jun 12, 2023

What does this PR do?

This PR fixes a bug where saving a checkpoint in training was called incorrectly and not saving the state and logger

What issue(s) does this change relate to?

This change fixes CO-2178

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@KuuCi KuuCi requested a review from dakinggg June 12, 2023 21:24
@KuuCi KuuCi changed the title still needs manual test CO-2178 Fix Jun 12, 2023
dakinggg
dakinggg approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update the PR title to describe the changes?

@KuuCi KuuCi changed the title CO-2178 Fix Fixed how save_checkpoint_to_save_folder called CheckpointSaver object to save state and logger Jun 12, 2023
@KuuCi KuuCi merged commit 63916e1 into mosaicml:dev Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakinggg dakinggg dakinggg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KuuCi @dakinggg