Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix daily tests by patching cupy version #2274

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

mvpatel2000
Copy link
Contributor

What does this PR do?

We changed dockerfile cupy version, but forgot to update notebook, so it installs the wrong version in tests. Fixes daily

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@dakinggg dakinggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming you ran the notebook and it works

@mvpatel2000 mvpatel2000 merged commit de22f8a into mosaicml:dev Jun 2, 2023
@mvpatel2000 mvpatel2000 deleted the mvpatel2000/fix-daily branch June 2, 2023 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants