Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add callbacks for EVAL_BEFORE_ALL and EVAL_AFTER_ALL #2264

Merged
merged 4 commits into from
Jun 1, 2023

Conversation

rishab-partha
Copy link
Contributor

@rishab-partha rishab-partha commented May 31, 2023

What does this PR do?

For multiple use cases, such as weight norm calculations, and logging after all evaluators run, we want to add events before and after all evaluators, termed EVAL_BEFORE_ALL and EVAL_AFTER_ALL. To do this, we modify the documentation and the workflow for the _run_evaluators function in order to first cache the results of whether evaluators run and add these events if that occurs.

What issue(s) does this change relate to?

N/A

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Will approve after tests are added to test_event.py

@rishab-partha
Copy link
Contributor Author

LGTM! Will approve after tests are added to test_event.py

Just added tests!

Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!!

tests/test_events.py Outdated Show resolved Hide resolved
@rishab-partha rishab-partha merged commit a7b0d35 into mosaicml:dev Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants