Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for saving HF info in state dict when using DDP #2206

Merged
merged 4 commits into from
May 6, 2023
Merged

Add support for saving HF info in state dict when using DDP #2206

merged 4 commits into from
May 6, 2023

Conversation

dakinggg
Copy link
Contributor

@dakinggg dakinggg commented May 6, 2023 •
edited by jira bot
Loading

What does this PR do?

Fixes an issue where HF info was not being saved if the model was DDP wrapped

What issue(s) does this change relate to?

Closes CO-2077

Before submitting

  • Have you read the contributor guidelines?
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@dakinggg dakinggg marked this pull request as ready for review May 6, 2023 00:40
@dakinggg dakinggg requested a review from mvpatel2000 May 6, 2023 00:40
mvpatel2000
mvpatel2000 approved these changes May 6, 2023
View reviewed changes
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole DDP wrap is a mess. We should do what FSDP did and wrap the inside module... but oh well

@dakinggg
Copy link
Contributor Author

dakinggg commented May 6, 2023

Yes, we absolutely should do that :)

@dakinggg dakinggg enabled auto-merge (squash) May 6, 2023 00:49
@dakinggg dakinggg merged commit 1c8cb72 into mosaicml:dev May 6, 2023
@dakinggg dakinggg deleted the hf-ddp branch June 1, 2023 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvpatel2000 mvpatel2000 mvpatel2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dakinggg @mvpatel2000