Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Checkpoints Simplified (#2059)" #2070

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Conversation

dakinggg
Copy link
Contributor

@dakinggg dakinggg commented Mar 15, 2023

This reverts commit b25b7f0.

What does this PR do?

This reverts the refactor PR, which we are going to break up into individual PRs to fix the relevant issues. There will be four follow on PRs to fix:

  1. the checkpoint download takes a long time, causing non zero ranks to timeout
  2. autoresume + FSDP sharded checkpoints not working
  3. skip the download on non local rank 0 ranks if not necessary
  4. update dist timeout everywhere

What issue(s) does this change relate to?

Before submitting

  • Have you read the contributor guidelines?
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@dakinggg dakinggg marked this pull request as ready for review March 15, 2023 04:00
Copy link
Contributor

@eracah eracah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eracah eracah merged commit 0ce9a13 into mosaicml:dev Mar 15, 2023
bandish-shah pushed a commit that referenced this pull request Mar 15, 2023
@dakinggg dakinggg deleted the revert_again branch June 1, 2023 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants