Daily tests #1870
Merged
Daily tests #1870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakinggg
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Migrates daily tests to GHA. Now, tests marked with
@pytest.mark.dailywill run every time a PR is merged into dev/main and every night at 2:30am (github recommends picking a randomish time as opposed to midnight to avoid load spikes).Along for the ride, a few tweaks to notebook tests to speed them up and avoid OOMs in the smaller GHA machines.
To verify tests passed, I opened a PR in my fork and changed workflow to run on pull requests as well. mvpatel2000#26 Commit
change workflowshas all tests passing before I set it to only run on merges (push) and scheduled cronNote: This is still only CPU tests. GPU tests will be added later
Note: We currently run all
pytest.mark.remotetests only in the daily tests because hitting real servers is expensive. We maintain theremotemarker in this PR though since this decision might be changed later.What issue(s) does this change relate to?
CO-1519