Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more useful info to state #1848

Merged
merged 7 commits into from
Jan 9, 2023
Merged

Conversation

dakinggg
Copy link
Contributor

@dakinggg dakinggg commented Dec 24, 2022

What does this PR do?

Adds more things to the metadata on state: device, precision, world size, microbatch size, dataloader batch size

What issue(s) does this change relate to?

Part of CO-1428

Before submitting

  • Have you read the contributor guidelines?
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dakinggg dakinggg merged commit 5a51b79 into mosaicml:dev Jan 9, 2023
bmosaicml pushed a commit to bmosaicml/composer that referenced this pull request Jan 9, 2023
@dakinggg dakinggg deleted the checkpoint_stuff branch September 9, 2023 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants