Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix doc issue, Trainer hparam log_to_console defaults to False #1840

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Fix doc issue, Trainer hparam log_to_console defaults to False #1840

merged 1 commit into from
Dec 20, 2022

Conversation

eracah
Copy link
Contributor

@eracah eracah commented Dec 20, 2022

What does this PR do?

fixes doc default value for log_to_console

What issue(s) does this change relate to?

fix CO-1576

Before submitting

  • Have you read the contributor guidelines?
  • Is this change a documentation change or typo fix? If so, skip the rest of this checklist.
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@eracah eracah marked this pull request as ready for review December 20, 2022 00:35
@bandish-shah bandish-shah changed the title Fix doc issue Fix doc issue, Trainer hparam log_to_console defaults to False Dec 20, 2022
bandish-shah
bandish-shah approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@bandish-shah bandish-shah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@eracah eracah merged commit 218ff22 into mosaicml:dev Dec 20, 2022
bandish-shah pushed a commit to bandish-shah/composer that referenced this pull request Dec 20, 2022
@eracah
Fix doc issue (mosaicml#1840)
2836732
bmosaicml pushed a commit to bmosaicml/composer that referenced this pull request Dec 22, 2022
@eracah @bmosaicml
Fix doc issue (mosaicml#1840)
3f7f841
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bandish-shah bandish-shah bandish-shah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eracah @bandish-shah