Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Huggingface pretrain + finetune notebook #1775

Merged
merged 14 commits into from
Dec 3, 2022
Merged

Huggingface pretrain + finetune notebook #1775

merged 14 commits into from
Dec 3, 2022

Conversation

dakinggg
Copy link
Contributor

@dakinggg dakinggg commented Dec 2, 2022

What does this PR do?

Adds a notebook with a tutorial for pretraining and finetuning a hugging face model

What issue(s) does this change relate to?

Closes CO-1444

Before submitting

  • Have you read the contributor guidelines?
  • Was this change discussed/approved in a GitHub issue first? It is much more likely to be merged if so.
  • Did you update any related docs and document your change?
  • Did you update any related tests and add any new tests related to your change? (see testing)
  • Did you run the tests locally to make sure they pass?
  • Did you run pre-commit on your change? (see the pre-commit section of prerequisites)

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@dakinggg dakinggg marked this pull request as ready for review December 2, 2022 02:32
@dakinggg dakinggg requested a review from a team as a code owner December 2, 2022 05:28
mvpatel2000
mvpatel2000 approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@mvpatel2000 mvpatel2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Approving since u need one from eng, but we should get a stamp from sam or alex as well

@samhavens samhavens self-requested a review December 2, 2022 18:58
samhavens
samhavens approved these changes Dec 2, 2022
View reviewed changes
Copy link

@samhavens samhavens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that sentence it LGTM

@dakinggg dakinggg merged commit 86eccee into mosaicml:dev Dec 3, 2022
@dakinggg dakinggg deleted the hf_finetune_notebook branch December 8, 2022 17:44
bmosaicml pushed a commit to bmosaicml/composer that referenced this pull request Dec 13, 2022
@dakinggg @bmosaicml
Huggingface pretrain + finetune notebook (mosaicml#1775)
2f4403d 
Adds an example notebook for pretrain + finetune using huggingface
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvpatel2000 mvpatel2000 mvpatel2000 approved these changes

@samhavens samhavens samhavens approved these changes

@alextrott16 alextrott16 Awaiting requested review from alextrott16

@bandish-shah bandish-shah Awaiting requested review from bandish-shah

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dakinggg @samhavens @mvpatel2000