Remove log level and should_log_artifact #1603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eracah
approved these changes
Oct 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes the
should_log_artifactwhich was unused as far as we know, and would require a user writing a custom filter function that takes in state andLogLevelto decide whether to log an artifact. Also, theWandBLoggerdid not support this argument.should_log_artifactwas also the only use ofLogLevel, so that has been removed everywhere.What issue(s) does this change relate to?
Closes CO-1189
Relates to CO-1167
Manual testing
Manually tested saving (loading) checkpoints to (from) WandB and S3.