Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update context to raise errror #1561

Merged
merged 7 commits into from
Sep 26, 2022
Merged

Update context to raise errror #1561

merged 7 commits into from
Sep 26, 2022

Conversation

mvpatel2000
Copy link
Contributor

@mvpatel2000 mvpatel2000 commented Sep 26, 2022 •
edited
Loading

Context now raises error if dist is not initialized instead of silently being skipped. Resolves https://mosaicml.atlassian.net/browse/CO-1107

hanlint
hanlint approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@hanlint hanlint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should we add a test for this?

@mvpatel2000 mvpatel2000 merged commit 78b6607 into mosaicml:dev Sep 26, 2022
@mvpatel2000 mvpatel2000 deleted the mvpatel2000/sampling-fixes branch September 26, 2022 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanlint hanlint hanlint approved these changes

@alextrott16 alextrott16 Awaiting requested review from alextrott16

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvpatel2000 @hanlint