Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Pandoc to Docker images, bump version to 2.19.2 #1550

Merged
merged 4 commits into from
Sep 21, 2022
Merged

Add Pandoc to Docker images, bump version to 2.19.2 #1550

merged 4 commits into from
Sep 21, 2022

Conversation

bandish-shah
Copy link
Contributor

  • Previously relying on installing pandoc through the documentation build
  • PyPandoc PyPi wrapper seems to be unreliable, at the time of this PR the download_pandoc() function is broken
  • Solution: Install pandoc directly in the Docker image, will leave the conf.py as is to handle local builds

@bandish-shah bandish-shah requested a review from a team as a code owner September 21, 2022 19:04
@bandish-shah bandish-shah merged commit 1e76114 into mosaicml:dev Sep 21, 2022
@bandish-shah bandish-shah deleted the bandish/pandoc_fixes branch September 21, 2022 20:06
bandish-shah added a commit to bandish-shah/composer that referenced this pull request Sep 21, 2022
@bandish-shah
Add Pandoc to Docker images, bump version to 2.19.2 (mosaicml#1550)
77b5eb3 
* Add pandoc install to Dockerfile
* Bump pandoc version to 2.19.2
* Bumped PyPandoc version in conf.py to 2.19.2
bcui19 pushed a commit to bcui19/composer that referenced this pull request Sep 22, 2022
@bandish-shah @bcui19
Add Pandoc to Docker images, bump version to 2.19.2 (mosaicml#1550)
0b6b80e 
* Add pandoc install to Dockerfile
* Bump pandoc version to 2.19.2
* Bumped PyPandoc version in conf.py to 2.19.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvpatel2000 mvpatel2000 mvpatel2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bandish-shah @mvpatel2000