Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix recipe yamls for v0.8, add testing #1257

Merged
merged 4 commits into from
Jul 6, 2022
Merged

Fix recipe yamls for v0.8, add testing #1257

merged 4 commits into from
Jul 6, 2022

Conversation

hanlint
Copy link
Contributor

@hanlint hanlint commented Jul 5, 2022 •
edited by ravi-mosaicml
Loading

This PR:

  • fixes the recipe yamls to work with the latest version of COmposer
  • expands our test coverage to include those yamls to prevent future regressions

Note: this is a UX change, as the recipe yamls will now have default ssr ratios, as well as datasets path. @growlix what do you prefer? It's easy to patch the yaml during the test if you would prefer to keep those unfilled.

Closes https://mosaicml.atlassian.net/browse/CO-649

growlix
growlix approved these changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@growlix growlix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I don't have strong feelings one way or another about leaving required but user-specific hparams (e.g. datadir) empty w/ a comment vs. providing a default that will need to be overridden.

ravi-mosaicml
ravi-mosaicml reviewed Jul 5, 2022
View reviewed changes
Copy link
Contributor

@ravi-mosaicml ravi-mosaicml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hparams changes look fine, though see comments re: test case changes.

composer/trainer/devices/device_gpu.py Show resolved Hide resolved
tests/models/test_model_yamls.py Outdated Show resolved Hide resolved
ravi-mosaicml
ravi-mosaicml approved these changes Jul 6, 2022
View reviewed changes
Copy link
Contributor

@ravi-mosaicml ravi-mosaicml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks!

tests/models/test_model_yamls.py Show resolved Hide resolved
tests/models/test_model_yamls.py Outdated Show resolved Hide resolved
hanlint and others added 2 commits July 6, 2022 13:20
@hanlint @ravi-mosaicml
Update tests/models/test_model_yamls.py
eb23393 
Co-authored-by: ravi-mosaicml <ravi@mosaicml.com>
@hanlint
add precision
101d6ca
@hanlint hanlint enabled auto-merge (squash) July 6, 2022 20:28
@hanlint hanlint merged commit 14d1901 into mosaicml:dev Jul 6, 2022
ravi-mosaicml pushed a commit that referenced this pull request Jul 16, 2022
@hanlint @ravi-mosaicml
Fix recipe yamls for v0.8, add testing (#1257)
e0f78a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@growlix growlix growlix approved these changes

@ravi-mosaicml ravi-mosaicml ravi-mosaicml approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hanlint @growlix @ravi-mosaicml