Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeError: Subscripted generics cannot be used with class and instance checks #3348

Open
kbaltakys opened this issue May 31, 2024 · 2 comments
Open

TypeError: Subscripted generics cannot be used with class and instance checks #3348

kbaltakys opened this issue May 31, 2024 · 2 comments

Comments

@kbaltakys
Copy link

isinstance(device_train_microbatch_size, Union[int, float])
should be
isinstance(device_train_microbatch_size, (int, float))
on line

composer/composer/trainer/trainer.py

Line 298 in 3c0a817

elif isinstance(device_train_microbatch_size, Union[int, float]):

@mvpatel2000
Copy link
Contributor

Good point! Would you mind opening a PR and tagging me for review?

@mvpatel2000 mvpatel2000 mentioned this issue May 31, 2024
Merged
@mvpatel2000
Copy link
Contributor

Quick fix just did it. Thanks for flagging!

@snarayan21 snarayan21 mentioned this issue Jun 6, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kbaltakys @mvpatel2000