Skip to content

Commit

Permalink
fix (interceptor): filter webpack hot update url from log
Browse files Browse the repository at this point in the history
  • Loading branch information
ronlanger authored and morsdyce committed Apr 25, 2021
1 parent e19cf6f commit 208e94e
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 1 deletion.
3 changes: 2 additions & 1 deletion lib/ui/components/RequestLogs/RequestLog.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import API from 'api';
import EVENTS from 'api/constants/events';
import RequestLogState from 'ui/states/RequestLogState';
import { connectToState } from 'ui/states/connector';
import { filterLogByType } from 'ui/utils/filters';
import { filterLogByType, filterByIgnoreList } from 'ui/utils/filters';
import { RequestOptionSpacer } from 'ui/components/QuickEdit/styled';
import Frame from 'ui/components/common/Frame';
import HeaderCell from 'ui/components/RequestLogs/HeaderCell';
Expand Down Expand Up @@ -58,6 +58,7 @@ class RequestLog extends React.Component {
return API.capturedRequests
.filter((request) => includes(request.url, RequestLogState.query))
.filter(filterLogByType)
.filter(filterByIgnoreList)
.map(renderRequestRow)
.reverse();
};
Expand Down
3 changes: 3 additions & 0 deletions lib/ui/constants/excluded-urls.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
export const EXCLUDED_URLS = [/hot-update.json/]

export default EXCLUDED_URLS
12 changes: 12 additions & 0 deletions lib/ui/utils/filters.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import MocksState from 'ui/states/MocksState';
import RequestLogState from 'ui/states/RequestLogState';
import EXCLUDED_URLS from 'ui/constants/excluded-urls';

export const filterMocksByType = (mock) => {
const status = mock.response.status;
Expand Down Expand Up @@ -43,3 +44,14 @@ export const filterLogByType = (request) => {
return true;
}
};

export const glob = (pattern, input) => {
return pattern.test(input);
}

export const filterByIgnoreList = (request) => {
const hasMatch = EXCLUDED_URLS.some((ignorePattern) => {
return glob(ignorePattern, request.url)
})
return !hasMatch;
}

0 comments on commit 208e94e

Please sign in to comment.