fix(NODE-6016): flip byte order depending on system endianness #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
W-A-James
added
the
Primary Review
addaleax
previously approved these changes
Mar 12, 2024
W-A-James
approved these changes
Mar 12, 2024
baileympearson
approved these changes
Mar 12, 2024
addaleax
approved these changes
Mar 12, 2024
This was referenced May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Flipped the order we parse bytes from the float array depending on platform endianness
Is there new documentation needed for these changes?
No.
What is the motivation for this change?
Floats will not serialize or deserialize correctly on big endian systems
Release Highlight
Fixed float byte-wise handling on big endian systems
A recent change to the BSON library started parsing and serializing floats using a
Float64Array. When reading the bytes from this array the ordering is dependent on the platform it is running on and we now account for that ordering.Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript