Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-3390): serialize non-finite doubles correctly in EJSON #445

Merged
merged 1 commit into from
Jul 2, 2021
Merged

fix(NODE-3390): serialize non-finite doubles correctly in EJSON #445

merged 1 commit into from
Jul 2, 2021

Conversation

addaleax
Copy link
Contributor

Description

In relaxed mode, non-finite doubles are supposed to be serialized
the same way as in non-relaxed/canonical mode.

@addaleax
fix(NODE-3390): serialize non-finite doubles correctly
1d1a58a 
In relaxed mode, non-finite doubles are supposed to be serialized
the same way as in non-relaxed/canonical mode.
@addaleax addaleax changed the title fix(NODE-3390): serialize non-finite doubles correctly fix(NODE-3390): serialize non-finite doubles correctly in EJSON Jun 28, 2021
nbbeeken
nbbeeken approved these changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for catching this!

To the team: I made NODE-3396 to follow up and address the corpus tests not catching this, essentially we're round tripping relaxed EJSON through native JS which over looked this case.

@nbbeeken nbbeeken requested review from durran and emadum July 1, 2021 15:16
@nbbeeken nbbeeken added the Team Review Needs review from team label Jul 1, 2021
emadum
emadum approved these changes Jul 2, 2021
View reviewed changes
Copy link
Contributor

@emadum emadum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nbbeeken nbbeeken merged commit 7eb7998 into mongodb:master Jul 2, 2021
@github-actions github-actions bot mentioned this pull request May 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emadum emadum emadum approved these changes

@nbbeeken nbbeeken nbbeeken approved these changes

@durran durran Awaiting requested review from durran

Assignees
No one assigned
Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@addaleax @emadum @nbbeeken