Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart provider runtime if required when we start scanning a new asset #4589

Closed
chris-rock opened this issue Aug 21, 2024 · 1 comment
Closed
Assignees
Labels
enhancement New feature or request

Comments

@chris-rock
Copy link
Member

chris-rock commented Aug 21, 2024

Describe the bug

You scan 100 assets of the same type. At 51 the provider crashes for any reason. Then all following assets using the same provider also return errors since the provider runtime is not restarted.

To Reproduce

Scan multiple assets of same type eg. with asset inventory. Force a panic during the first scan eg. by returning a panic when a resource is called. All following assets return as error.

Related to missing check here

// TODO: we probably want to check here if the provider is dead and restart it
// if r.Provider.Instance.isCloseOrShutdown() {
// }

Expected behavior

Within a scan we do not recover the runtime. We only check for a dead runtime when we start scanning a new asset. If the runtime is dead, we restart the provider. Otherwise we keep the existing runtime as we do right now.

@chris-rock chris-rock added the enhancement New feature or request label Aug 21, 2024
@vjeffrey
Copy link
Contributor

vjeffrey commented Sep 3, 2024

#4591

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants