Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inventory passed in asset names not respected #4240

Open
preslavgerchev opened this issue Jun 14, 2024 · 0 comments
Open

Inventory passed in asset names not respected #4240

preslavgerchev opened this issue Jun 14, 2024 · 0 comments

Comments

@preslavgerchev
Copy link
Contributor

If we have more than 2 assets in an inventory file, the names that are passed in are not respected. This happens due to this piece of code https://github.com/mondoohq/cnquery/blob/main/explorer/scan/discovery.go#L145.

We should ensure either that the discovery code respects all passed in names or ensure that each provider does that: if the asset name is already set, we do not touch it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant