dev/master candidate 2019-08-30 #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed commented out controlled_forcing calls and other code from the ice_solo_driver, mct_driver, and nuopc_driver code. This capability has never been completed, so until it is working, it is only being retained (in commented out form) in the coupled_driver code. All answers are bitwise identical.
Rescaled the units of pbce to L2 H-1 T-2 from m2 H-1 s-2 for enhanced dimensional consistency testing. All answers are bitwise identical.
Rescaled the units of fluxes%buoy to L2 T-3 from m2 s-3 for enhanced dimensional consistency testing. This required the addition of unit_scale_type arguments to several initialization or buoyancy flux routines. All answers are bitwise identical.
Rescaled the units of buoyancyFlux returned by the calculateBouyancyFlux routines and the units of the buoyFlux arguments to KPP_calculate and KPP_compute_BLD, all of which are now in [L2 T-3] for dimensional consistency testing. All answers are bitwise identical.
Rescaled the internal representation of diagnostics in entrainment_diffusive. All answers are bitwise identical.
Rescaled the internal representation of commented out diagnostics and added some clarifying comments in find_TKE_to_Kd. All answers are bitwise identical.
Rescaled the internal representation of commented out diagnostics in applyBoundaryFluxesInOut. All answers are bitwise identical.
Explicitly set the sizes of optics-related arguments to mixedlayer_convection, mechanical_entrainment, and sumSWoverBands so that these arrays do not alwasy have to start at 1, thereby facilitating global indexing. This involves adding a new integer argument to sumSWoverBands. All answers are bitwise identical.
Added a new runtime paramter, KELVIN_WAVE_2018_ANSWERS, to select code that changes to expressions that are rotationally symmetric and avoids problems that could arise from spatially varying coefficients that are not being recalculated within apatial loops. By default all answers are bitwise identical, but the MOM_parameter_doc files have a new entry if USE_KELVIN_WAVE_OBC is true.
Replaced GV%g_Earth with the fully dimensionally rescaled GV%LZT_g_Earth, the MKS variable GV%mks_g_Earth, or other combinations of variables, like GV%Z_to_H and GV%H_to_Pa, throughout the MOM6 code. All answes are bitwise identical.
Renamed GV%LZT_g_Earth to GV%g_Earth and eliminated the separate GV%g_Earth, which is no longer in use anywhere in the MOM6 code. All answers are bitwise identical.
Changed the dimensions of the variables used to calculate a bulk Richardson number in set_viscous_ML to use units of L2 T-2 for velocities squared. All answers are bitwise identical.
There are two versions of vert_fill_TS in MOM_isopycnal_slopes.F90 and MOM_thickness_diffuse.F90. This commit changes how they handle massless layers and brings the two versions closer together, including combining the diffusivity and timestep arguments into a single argument of their product and adding a new optional logical argument to cause the isopycnal_slopes version to reproduce the answers from the thickness_diffuse version. Also added a the existing runtime parameter KD_SMOOTH to MOM_set_diffusivity for use when SET_DIFF_2018_ANSWERS is false, but this does not change the MOM_parameter_doc files. All answers are bitwise identical in the existing MOM6-examples test cases, but there could be answer changes when there are zero thickness layers.
Removed the version of vert_fill_TS from MOM_thickness_diffuse.F90 because identical functionality can be obtained via MOM_isopycnal_slopes, provided that the optioanl argument larger_h_denom=.true. is used. All answers are bitwise identical, but there has been a relocation to a new module and a slight change in one of the public interfaces.
The MEKE criteria for using the FrictWorkMax diagnostic was not sufficient, since it is possible to use MEKE while still unable to compute some of the terms required for FrictWorkMax. We resolve this by adding the MEKE_type struct as an argument for hor_visc_init, and use the same information when computing FrictWorkMax to determine whether to register FrictWorkMax. This changes the API by adding MEKE to most of the timestep initializations, but should not affect answers.
Added the runtime parameter HOR_VISC_2018_ANSWERS to permit the elimination of a dimensional constant without changing answers. Rescaled the units of several time variables in MOM_hor_visc. Also added comments indicating issues with the GME options and suggests for how to correct them. All answers are bitwise identical, but there is a new entry in the MOM_parameter_doc files.
Changed the units of diffu and diffv as returned by MOM_hor_visc to [m s-1 T-1] for dimensional consistency testing. Additional unit changes will come automatically after the units of horizontal viscosities are rescaled. All answers are bitwise identical, but the units of some arguments to public functions and elements of types have been rescaled.
Changed the units of the 6 str_xx and str_xy variables in MOM_hor_visc to [H m2 s-1 T-1] for dimensional consistency testing. All answers are bitwise identical.
Changed the units of lateral viscosities to [m2 T-1] and the units of biharmonic viscosities to [m4 T-1] in MOM_hor_visc.F90 for expanded dimensional consistency testing. All answers are bitwise identical.
Changed the units of the timestep to [T} in hor_visc_init and of vert_vort_mag to [T-1 m-1] in horizontal_viscosity. Also added a variant of the grad_vel_mag_h calculation with parentheses for rotational symmetry when answers_2018 = False. Changed the marks around suggestions for correcting issues with the recently added GME code to #GME# to help in finding them. All answers are bitwise identical.
Stronger conditional registration of FrictWorkMax
Changed the units of MEKE%Ku and MEKE%Au to [m2 T-1], including adding code to allow for the dimensional scaling to change across restarts and moving the halo updates on any MEKE variables read from restart files to the end of MEKE_init. Also change the units of GME_coeff in horizontal_viscosity to [m2 T-1]. This also required adding a unit_scale_type argument to MEKE_init. All answers are bitwise identical, but the units for some variables in a publicly visible type have changed.
Combined halo updates inside of the MEKE code into group passes to reduce latency. Also made del2MEKE into a local variable and removed it from the MEKE control structure. All answers are bitwise identical.
Eliminated an unnecessary halo update in horizontal_viscosity. All answers are bitwise identical.
Added a new runtime parameter, VERY_SMALL_FREQUENCY, to control how close to zero some frequencies that appear in the denominator of some expressions for the resolutoin functions can get. Also added some comments and rearranged some code addressing problems in calc_QG_Leith_viscosity. By default, all answers in the MOM6-examples test cases are bitwise identical, but there is a new entry in the MOM_parameter_doc.all files.
This patch remaps the opacity diagnostic to a tanh function, i.e.
op -> 1/L * tanh(op * L)
where L is arbitrarily set to 10^-10 (1 Angstrom). For op << 1/L, the
diagnostic is nearly equivalent to the model opacity. For values
comparable and larger than L, the diagnostic approaches 1/L, a
sufficiently large value to reproduce the effects of a divergent
opacity.
This allows us to safely manipulate and store the opacity while also
avoiding infinite values and floating point overflow.
This change will modify the opacity diagnostic, but should not affect
the dynamic state.
Rescaled the units of the f2_dx2_... and beta_dx2_... elements of VarMix_CS. These particular arrays are only used in calc_resoln_function, and because these are raised to arbitrary powers they have to be rescaled back to mks units in some cases. All answers are bitwise identical in the MOM6-examples test cases.
This PR updates the README to include instructions for the test suite Makefile. It also fixes a bug in the travis config file which may have been preventing code coverage updates.
The variables used for calculating internal heat in MOM_geothermal.F90 relied on zero-initialization due to the conditional do_i() check inside of the loops, which was producing NaN warnings in our test suite. This patch resolves this by conditionally initializing the fields based on diagnostic registration. It also introduces two new logical variables to control the initialization and evaluation of the arrays.
ocean.stats and chksum_diag output is now tagged as PRECIOUS, and is retained after a run. This helps to identify an issue after a fail. .gitignore was also restructured to move the test ignore rules into a subdirectory. Finally, we no longer rely on (-) to ignore commands in Makefile, since it was causing odd issues after PRECIOUS was introduced. We now just explicitly ignore any commands by piping nonzero commands to `true`.
Initialize geothermal internal heat diagnostics
f90nml is no longer used to modify the input.nml files for restart runs, since it was adding an unnecessary dependency. Code coverage is now conditionally enabled for the symmetric build, and controlled by the REPORT_COVERAGE flag, since it can significantly increase the build and run times.
The z-interpolated uhml and vhml diagnostics gave inconsistent answers across layouts when using the general mixed layer restratification scheme, because the value of h had changed but its halos had not been updated. This had been previously fixed in the BML restratification but not the general stratification method. This patch updates the value of h by conditionally updating the halos if this diagnostic is required.
This PR enables coverage cleanup and CodeCov upload for test runs. It also introduces an optional configuration file, config.mk which can be used for user-configured settings, such as templates or mpirun commands.
Path rules for cleaning up old code coverage files (*.gcda) and for running the CodeCov.io upload script have been fixed.
- The OBC tracer reservoirs were being updated in MOM_tracer_advect - twice each! Update them separately after tracer advection. - The OBC tracer lengthscale was being cubed to get the volume. Change that to a lengthscale times the face area where the advection is happening. - Changes answers if the tracer lengthscales were not set to zero.
- Could make it more verbose to let the user know which data are missing.
Travis: config.mk user config; enable coverage
*Add new update_segment_tracer_reservoirs routine
(*) Bugfix: [uv]hml z-diags in general restrat
- As agreed on the MOM6 dev call, we renamed MOM_surface_forcing.F90 to help distinguish it from the other caps. It is now called MOM_surface_forcing_gfdl.F90.
|
I approve this PR. |
|
We approve this PR. |
|
I approve this PR. |
|
Works fine in EMC side, approve this PR.
…On Fri, Aug 30, 2019 at 2:43 PM Alistair Adcroft ***@***.***> wrote:
This PR submits everything on dev/gfdl as of 2019/08-30 to dev/master. As
per usual feedback from @gustavo-marques
<https://github.com/gustavo-marques>, @awallcraft
<https://github.com/awallcraft>, @kshedstrom
<https://github.com/kshedstrom> and @jiandewang
<https://github.com/jiandewang> is asked for before we accept this PR.
Main features:
- *.testing*: Unbeknownst to most of you, the tests run on Travis-CI
have been managed by the contents of the .testing directory for a while. We
have now removed the inverse dependency on MOM6-examples and have defined
some rudimentary test configurations (TCs) within the .testing. These are
not usable configurations for science but sufficient for some code tests.
If you have connected Travis-CI to your GitHub fork then with each push you
will now invoke tests for 1) restarts, 2) decomposition, 3) dimension
scaling, 4) symmetric/non-symmetric memory, 5) uninitialized data, and 6)
optimization tolerance. A pull request also conducts a regression test
against the parent branch. If Travis-CI is showing you a red X then you can
now run the tests interactively. See the .testing/README.md for pointers.
@marshallward <https://github.com/marshallward> has made all this work
and will be expanding the coverage of these tests on the dev/gfdl branch
over the coming months.
- *Dimensional scaling*: @Hallberg-NOAA
<https://github.com/Hallberg-NOAA> has touched a lot of code to test
that expressions are dimensionally consistent and to allow us to continue
to test expressions (this is the reason for the number of commits in this
PR).
- *OBC fixes*: @kshedstrom <https://github.com/kshedstrom> and
@MJHarrison-GFDL <https://github.com/MJHarrison-GFDL> have been fixing
bugs in the open boundary code that does not affect most configurations but
since the code is beginning to be used in regional configurations beware.
- *Answer changes*: Numerous fixes have been implemented in
diagnostics and forward code. Where the latter changed answers, we made the
changes run-time conditional which has introduced numerous flags. By
default, all these flags are set to *not* change answer but subsequent
to this PR we will be rolling forward all the GFDL configurations to give
new (corrected) answers. We recommend evaluating each of the new flags to
see if you can move to the newer code so that in the future when we
eventually remove the old code you are not adversely affected. The flags
are:
- EPBL_2018_ANSWERS
- HOR_VISC_2018_ANSWERS
- OPTICS_2018_ANSWERS
- SET_DIFF_2018_ANSWERS
- SET_VISC_2018_ANSWERS
- SURFACE_FORCING_2018_ANSWERS
- TIDAL_MIXING_2018_ANSWERS
- WIND_GYRES_2018_ANSWERS
There are no answer changes implied for the MOM6-examples configurations
but because of new parameters a branch with the same name has been pushed
to
https://github.com/NOAA-GFDL/MOM6-examples/tree/dev-master-candidate-2019-08-30
.
------------------------------
You can view, comment on, or merge this pull request online at:
https://github.com/NOAA-GFDL/MOM6/pull/988
Commit Summary
- Merge branch 'dev/master' into dev/gfdl
- Removed commented out controlled_forcing codes
- +Rescaled the units of pbce
- +Rescaled the units of fluxes%buoy
- +Rescaled buoyancyFlux variable units
- Rescaled diagnostics in entrainment_diffusive
- escaled comments in find_TKE_to_Kd
- Rescaled comments in applyBoundaryFluxesInOut
- +Explicitly set optics-related array sizes
- (+*)Added KELVIN_WAVE_2018_ANSWERS runtime parameter
- Replaced GV%g_Earth with other variables
- +Replaced GV%LZT_g_Earth with GV%g_Earth
- Rescaled variables in set_viscous_ML
- (*)+Harmonized the two versions of vert_fill_TS
- +Removed one variant of vert_fill_TS
- Merge branch 'dev/gfdl' into code_units_cleanup
- Stronger conditional registration of FrictWorkMax
- +Added HOR_VISC_2018_ANSWERS & rescaled variables
- +Changed the units of diffv to [m s-1 T-1]
- Changed the units of str_xx to [H m2 s-1 T-1]
- Changed laterat viscosity units to [m2 T-1]
- Changed the timestep units to [T} in hor_visc_init
- Merge pull request #950 from marshallward/frictworkmax_v3
- fix indexing error for salt OBC reservoir
- +Changed the units of MEKE%Ku [m2 T-1]
- Grouped MEKE halo updates
- Removed a halo update in horizontal_viscosity
- +Added the runtime parameter VERY_SMALL_FREQUENCY
- (*) Remap opacity diagnostic to tanh()
- Rescaled the units of VarMix_CS%f2_dx2_h
- Merge branch 'dev/gfdl' into code_units_cleanup
- Merge pull request #952 from marshallward/tanh_opacity
- Merge branch 'code_units_cleanup' of
https://github.com/Hallberg-NOAA/MOM6 into
Hallberg-NOAA-code_units_cleanup
- Merge branch 'Hallberg-NOAA-code_units_cleanup' into dev/gfdl
- More useful message when detecting bad surface state
- Allows vector-of-reals debugging parameters
- Merge pull request #955 from adcroft/fix-bad-val-output
- Merge pull request #956 from
adcroft/allow-vector-real-debugging-param
- KE_adv diag calculation using mask2d
- Conditional registration of KPP_OBLdepth_original
- Merge branch 'dev/gfdl' into diag_keadv_oblorig
- Merge pull request #957 from marshallward/diag_keadv_oblorig
- Use f2e2c86 commit for FMS in .testing
- Adding scale_factor and add_offset for MOM_horizontal_regridding.F90
netCDF inputs in horiz_interp_and_extrap_tracer_record
- unit change, fix #934
- Merge pull request #959 from adcroft/fms-f2e2c86f6c0
- Merge branch 'dev/esmg' into obc_index_error_patch
- Merge branch 'dev/gfdl' into hiprec
- Merge branch 'obc_index_error_patch' into dev/esmg
- Merge branch 'fix_transport_units' of
https://github.com/raphaeldussin/MOM6 into
raphaeldussin-fix_transport_units
- Merge branch 'raphaeldussin-fix_transport_units' into dev/gfdl
- Merge pull request #960 from
breichl/user/bgr/Init_from_Z_add_scale_offset
- Merge branch 'dev/gfdl' into hiprec
- Merge branch 'marshallward-hiprec' into dev/gfdl
- Merge remote-tracking branch 'gfdl/dev/gfdl' into dev/esmg
- Rescaled units in MOM_barotropic.F90
- +Rescaled barotropic_CS%ubtav and vbtav
- +Rescaled elements of the BT_cont_type
- Merge pull request #963 from Hallberg-NOAA/barotropic_rescale
- +Rescaled uhtr and vhtr
- Merge branch 'dev/gfdl' into transport_rescale
- +Rescaled uh and vh to [H L2 T-1]
- Cleanup of rescaling factors in energy diagnostics
- Corrected chksum scaling for vertvisc_CS%h_u
- +Changed the units of uhbt and vhbt to [H L2 T-1]
- +Eliminated uhbt_aux args from continuity_PPM
- Dimensional rescaling inside continuity_PPM.F90
- +Rescaled accelerations returned from btstep
- +Rescaled accelerations passed to btstep
- +Rescaled Coriolis accelerations
- Rescaled pressure gradient accelerations
- +Relocated rescaling of pressure gradient terms
- Rescaled variables in advect_tracer
- +Rescaled continuity internal calculations
- Add parentheses around grid metric arrays
- Bugfix: diabatic_salt_tendency diagnostics in ALE
- Merge branch 'dev/gfdl' into dia_diff_saln_fix
- Merge remote-tracking branch 'gfdl/dev/gfdl' into dev/esmg
- +Rescaled the units of G%Iarea arrays
- Simplified some G%Iarea unit-scaling expressions
- +Add G%US and rescale the units of G%area arrays
- +Rescaled the units of G%dy_Cu and G%dx_Cv
- +Rescaled the units of G%dyT and G%dxT
- +Rescaled the units of G%dxCu and G%dyCv
- +Rescaled the units of G%dyCu and G%dxCv
- +Rescaled the units of G%dxBu and G%dyBu
- +Rescaled the units of G%IdxBu and G%IdyBu
- +Rescaled the units of G%IdxT and G%IdyT
- +Rescaled the units of G%IdyCu and G%IdxCv
- +Rescaled the units of G%IdxCu and G%IdyCv
- Simplified rescaling in MOM_sum_output.F90
- Simplified rescaling in MOM_controlled_forcing.F90
- Simplified rescaling in MOM_MEKE.F90
- Simplified rescaling in MOM_hor_visc.F90
- Simplified rescaling in MOM_thickness_diffuse.F90
- Simplified rescaling in MOM_set_diffusivity.F90
- Simplified rescaling in MOM_vert_friction.F90
- Simplified rescaling in MOM_tracer_hor_diff.F90
- Merge pull request #969 from marshallward/dia_diff_saln_fix
- Rescaled internal variables in MOM_hor_visc.F90
- +Rescaled ubtav returned by barotropic_get_tav
- +Rescaled div_xx_dx sent to calc_QG_Leith_viscosity
- Renamed u0 to Del2u in horizontal_viscosity
- +Rescaled 9 elements of the MEKE_type
- +Rescaled horizontal viscosity accelerations
- (*)Eliminated a bug in horizontal viscosity work
- Rescaled internal variables in MOM_MEKE.F90
- +Rescaled G%dF_dx & G%dF_dy to units of [T-1 L-1]
- Rescaled variables in MOM_mixedlayer_restrat.F90
- Rescaled variables in MOM_thickness_diffuse.F90
- +Rescaled VarMix%L2u & VarMix%L2v to units of [L2]
- +Rescaled VarMix%SN_u and VarMix%SN_v to [T-1]
- +Rescaled VarMix%cg1 to units of [L T-1]
- Rescaled variables in MOM_lateral_mixing_coeffs.F90
- +Rescaled isoneutral & along layer tracer diffusion
- Correct rescaling diffu and diffv across restarts
- +Return N2_u from calc_isoneutral_slopes in [T-2]
- Rescaled variables in MOM_CoriolisAdv.F90
- +Rescaled OBC%segment%normal_vel to units of [L T-1]
- Rescaled OBC%segment%normal_trans to units of [H L2 T-1]
- +Rescaled OBC%segment%tangential_grad to [T-1]
- +Rescaled OBC%segment%grad_gradient to [m s-1 L-1]
- Unit scaling term cleanup in set_viscous_BBL
- Simplified scaling terms in find_uv_at_h
- Rescaled variables in MOM_internal_tides.F90
- +Rescaled CDp%uhGM diagnostics to [H L2 T-1]
- +Pass internal wave speeds in [L T-1]
- Rescaled variables in MOM_bulk_mixed_layer.F90
- Rescaled velocities in MOM_energetic_PBL.F90
- +Pass velocities to set_diffusivity in [L T-1]
- +Pass velocities to bulkmixedlayer in [L T-1]
- +Added thickness rescaling in MOM_state_stats
- +Pass velocities to diabatic in [L T-1]
- +Added optional vel_scale argument to MOM_state_chksum_5arg
- +Pass velocities to set_viscous_BBL in [L T-1]
- +Pass velocities to step_MOM_thermo in [L T-1]
- +Pass velocities to continuity in [L T-1]
- +Pass velocities to CorAdCalc in [L T-1]
- +Pass velocities to btstep in [L T-1]
- +Pass velocities to set_viscous_ML in [L T-1]
- +Pass velocities to vertvisc_coef in [L T-1]
- Code style modifications in wave_structure
- +Recast vertvisc to work with velocities in [L T-1]
- +Rescaled ADp%du_dt_visc to units of [L T-2]
- +Pass velocities to vertvisc in [L T-1]
- Velocities in [L T-1] in step_MOM_dyn_split_RK2
- +Pass vels to radiation_open_bdry_conds in [L T-1]
- *Get rid of uninitialized cff variable in OBC.
- MOM_dyn_split_RK2_CS%u_av in units of [L T-1]
- +Pass velocities to step_MOM_dyn_... in [L T-1]
- Introduced dt_in_T to step_MOM_dyn...
- +Point MIS%u_prev to MOM_control_struct%u_prev
- +Pass velocities to calculate_diagnostic_fields in [L T-1]
- +Change units of MOM_control_struct%u to [L T-1]
- +initialize_vel routines pass velocities in [L T-1]
- +Pass velocities to write_energy in [L T-1]
- +Pass timestep to continuity in [T]
- Rescaled MOM_open_boundary.F90 internal variables
- Simplified a logical test in step_forward_MEKE
- Merge branch 'dev/gfdl' into transport_rescale
- Merge branch 'dev/master' into dev/gfdl
- Merge branch 'dev/gfdl' into transport_rescale
- Allow dyed_obcs to be used with other OBC data inputs.
- Rescaled taux_bot and tauy_bot to [kg L Z T-2 m-3]
- Trying to check to see that OBC data is there if needed.
- Merge branch 'dev/gfdl' into dev/esmg
- changes needed for reproducibility across restarts using OBCs
- Merge branch 'dev/esmg' of github.com:ESMG/MOM6 into
tracer_advection_OBC
- remove commented code
- added diagnostic for internal heat in 3D
- further modifications to internal heat diagnostic
- fix indexing error in advect_y
- Travis test suite expansion
- Merge branch 'dev/gfdl' into new_travis
- Merge pull request #68 from ESMG/tracer_advection_OBC
- Explicit dependency for Travis path_names Makefile
- Redefined target PR branch name via Travis
- Makes OBC restart field rx_normal not required
- Source data are assumed to be zonally re-entrant.
- Merge branch 'dev/esmg' of github.com:ESMG/MOM6 into OBC_patches
- Merge pull request #69 from ESMG/OBC_patches
- testing stream
- add checks land values
- testing stream
- updated calculation of internal heat diagnostic
- Makefile local support
- duh
- pff
- included diagnostics for T and h from internal heat, and improved
logic
- minor adjustment
- removed whitespace
- fixed problem in conditional statements
- Merge branch 'Hallberg-NOAA-transport_rescale' into dev/gfdl
- Skip checkout/merge for non-regression tests
- Merge branch 'dev/gfdl' into internalheat3d
- Merge branch 'dev/gfdl' into new_travis
- Merge pull request #981 from gmacgilchrist/internalheat3d
- *Adjust Segment Data Thicknesses
- add more verbosity
- char len change
- change precision output string
- Fixed typo; removed old comment
- *Fixed routine for adjusting segment data thicknesses.
- Fix index error
- Merge pull request #72 from ESMG/OBC_segment_data_thickness_adjust
- Fixes answer changes due to incomplete copy of tracer array
- MKMF default template; Coverage report flag
- Fixing travis mkmf template path
- Merge branch 'dev/gfdl' of https://github.com/NOAA-GFDL/MOM6 into
OBC_tracer_advect_patch2
- Tiny tweak to Matt's giant merger
- Merge branch 'OBC_tracer_advect_patch2' into dev/esmg
- Travis: git management replaced with subdirectory
- Merge branch 'dev/gfdl' into new_travis
- fix alloc and give global indices
- Travis: Regression target as detached head
- Merge branch 'new_travis' of https://github.com/marshallward/MOM6
into new_travis
- Merge branch 'dev/gfdl' into mask_checks
- Travis: OpenMPI environment variable support
- Travis: Conditionally add -x flag for envars
- Makefile root moved to .testing; configure removed
- Fixed path of Travis mkmf template
- Merge branch 'ESMG-dev/esmg' into dev/gfdl
- add namelist param
- Merge branch 'mask_checks' of https://github.com/raphaeldussin/MOM6
into mask_checks
- shorter lines
- Merge branch 'dev/gfdl' into new_travis
- Merge branch 'mask_checks' of https://github.com/raphaeldussin/MOM6
into raphaeldussin-mask_checks
- Merge branch 'raphaeldussin-mask_checks' into dev/gfdl
- README update; travis bugfix
- Merge branch 'new_travis' of https://github.com/marshallward/MOM6
into new_travis
- Merge branch 'dev/gfdl' into new_travis
- Initialize geothermal internal heat diagnostics
- PRECIOUS output; gitignore restructure
- Merge pull request #984 from marshallward/geothermal_init
- Merge branch 'dev/gfdl' into new_travis
- Removed f90nml dependency; conditional coverage
- Merge branch 'new_travis' of https://github.com/marshallward/MOM6
into new_travis
- Fixed typo and added slurm section to .testing/README
- Merge branch 'marshallward-new_travis' into dev/gfdl
- (*) Bugfix: [uv]hml z-diags in general restrat
- Travis: config.mk user config; enable coverage
- Modify make test rule
- Travis: coverage path fixes
- *Add new update_segment_tracer_reservoirs routine
- Fixed the OBC checking for data and dying if missing.
- Merge pull request #986 from marshallward/enable_codecov
- Merge branch 'dev/gfdl' into dev/esmg
- Merge pull request #987 from ESMG/dev/esmg
- Merge pull request #985 from marshallward/uhml_bugfix_general
- Renamed MOM_surcace_forcing.F90 in coupler/ directory
File Changes
- *M* .gitignore
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-0> (16)
- *A* .testing/.gitignore
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-1> (13)
- *M* .testing/Makefile
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-2> (317)
- *M* .testing/README.md
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-3> (215)
- *D* .testing/configure
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-4> (4)
- *M* .testing/linux-ubuntu-xenial-gnu.mk
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-5> (8)
- *A* .testing/tc0/MOM_input
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-6> (229)
- *A* .testing/tc0/MOM_override
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-7> (0)
- *A* .testing/tc0/diag_table
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-8> (2)
- *A* .testing/tc0/input.nml
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-9> (20)
- *A* .testing/tc1/MOM_input
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-10> (576)
- *A* .testing/tc1/MOM_override
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-11> (0)
- *A* .testing/tc1/diag_table
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-12> (86)
- *A* .testing/tc1/input.nml
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-13> (19)
- *A* .testing/tc2/MOM_input
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-14> (614)
- *A* .testing/tc2/MOM_override
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-15> (0)
- *A* .testing/tc2/diag_table
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-16> (86)
- *A* .testing/tc2/input.nml
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-17> (19)
- *A* .testing/tc3/MOM_input
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-18> (471)
- *A* .testing/tc3/MOM_override
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-19> (0)
- *A* .testing/tc3/diag_table
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-20> (207)
- *A* .testing/tc3/input.nml
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-21> (17)
- *M* .travis.yml
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-22> (118)
- *R* config_src/coupled_driver/MOM_surface_forcing_gfdl.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-23> (269)
- *M* config_src/coupled_driver/ocean_model_MOM.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-24> (27)
- *M* config_src/ice_solo_driver/MOM_surface_forcing.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-25> (51)
- *M* config_src/ice_solo_driver/ice_shelf_driver.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-26> (2)
- *M* config_src/ice_solo_driver/user_surface_forcing.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-27> (20)
- *M* config_src/mct_driver/mom_ocean_model_mct.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-28> (15)
- *M* config_src/mct_driver/mom_surface_forcing_mct.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-29> (79)
- *M* config_src/mct_driver/ocn_cap_methods.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-30> (8)
- *M* config_src/mct_driver/ocn_comp_mct.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-31> (8)
- *M* config_src/nuopc_driver/mom_cap.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-32> (2)
- *M* config_src/nuopc_driver/mom_cap_methods.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-33> (8)
- *M* config_src/nuopc_driver/mom_ocean_model_nuopc.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-34> (19)
- *M* config_src/nuopc_driver/mom_surface_forcing_nuopc.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-35> (86)
- *M* config_src/solo_driver/MESO_surface_forcing.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-36> (19)
- *M* config_src/solo_driver/MOM_driver.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-37> (4)
- *M* config_src/solo_driver/MOM_surface_forcing.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-38> (160)
- *M* config_src/solo_driver/Neverland_surface_forcing.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-39> (20)
- *M* config_src/solo_driver/user_surface_forcing.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-40> (18)
- *M* config_src/unit_drivers/MOM_sum_driver.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-41> (2)
- *M* src/ALE/MOM_ALE.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-42> (22)
- *M* src/core/MOM.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-43> (207)
- *M* src/core/MOM_CoriolisAdv.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-44> (219)
- *M* src/core/MOM_PressureForce.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-45> (4)
- *M* src/core/MOM_PressureForce_Montgomery.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-46> (88)
- *M* src/core/MOM_PressureForce_analytic_FV.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-47> (48)
- *M* src/core/MOM_PressureForce_blocked_AFV.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-48> (40)
- *M* src/core/MOM_barotropic.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-49> (896)
- *M* src/core/MOM_boundary_update.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-50> (2)
- *M* src/core/MOM_checksum_packages.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-51> (145)
- *M* src/core/MOM_continuity.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-52> (57)
- *M* src/core/MOM_continuity_PPM.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-53> (575)
- *M* src/core/MOM_dynamics_split_RK2.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-54> (249)
- *M* src/core/MOM_dynamics_unsplit.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-55> (122)
- *M* src/core/MOM_dynamics_unsplit_RK2.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-56> (105)
- *M* src/core/MOM_forcing_type.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-57> (112)
- *M* src/core/MOM_grid.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-58> (82)
- *M* src/core/MOM_interface_heights.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-59> (4)
- *M* src/core/MOM_isopycnal_slopes.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-60> (91)
- *M* src/core/MOM_open_boundary.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-61> (626)
- *M* src/core/MOM_transcribe_grid.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-62> (11)
- *M* src/core/MOM_variables.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-63> (118)
- *M* src/core/MOM_verticalGrid.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-64> (11)
- *M* src/diagnostics/MOM_PointAccel.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-65> (167)
- *M* src/diagnostics/MOM_diagnostics.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-66> (177)
- *M* src/diagnostics/MOM_obsolete_params.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-67> (4)
- *M* src/diagnostics/MOM_sum_output.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-68> (57)
- *M* src/diagnostics/MOM_wave_speed.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-69> (20)
- *M* src/diagnostics/MOM_wave_structure.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-70> (55)
- *M* src/framework/MOM_diag_mediator.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-71> (14)
- *M* src/framework/MOM_diag_remap.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-72> (18)
- *M* src/framework/MOM_dyn_horgrid.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-73> (66)
- *M* src/framework/MOM_file_parser.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-74> (14)
- *M* src/framework/MOM_horizontal_regridding.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-75> (14)
- *M* src/framework/MOM_spatial_means.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-76> (16)
- *M* src/ice_shelf/MOM_ice_shelf.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-77> (61)
- *M* src/ice_shelf/MOM_ice_shelf_dynamics.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-78> (87)
- *M* src/ice_shelf/MOM_ice_shelf_initialize.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-79> (8)
- *M* src/ice_shelf/MOM_marine_ice.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-80> (12)
- *M* src/ice_shelf/user_shelf_init.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-81> (4)
- *M* src/initialization/MOM_coord_initialization.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-82> (45)
- *M* src/initialization/MOM_fixed_initialization.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-83> (14)
- *M* src/initialization/MOM_grid_initialize.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-84> (163)
- *M* src/initialization/MOM_shared_initialization.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-85> (132)
- *M* src/initialization/MOM_state_initialization.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-86> (104)
- *M* src/ocean_data_assim/MOM_oda_driver.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-87> (4)
- *M* src/parameterizations/lateral/MOM_MEKE.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-88> (618)
- *M* src/parameterizations/lateral/MOM_MEKE_types.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-89> (22)
- *M* src/parameterizations/lateral/MOM_hor_visc.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-90> (0)
- *M* src/parameterizations/lateral/MOM_internal_tides.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-91> (0)
- *M* src/parameterizations/lateral/MOM_lateral_mixing_coeffs.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-92> (0)
- *M* src/parameterizations/lateral/MOM_mixed_layer_restrat.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-93> (0)
- *M* src/parameterizations/lateral/MOM_thickness_diffuse.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-94> (0)
- *M* src/parameterizations/vertical/MOM_CVMix_KPP.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-95> (0)
- *M* src/parameterizations/vertical/MOM_CVMix_conv.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-96> (0)
- *M* src/parameterizations/vertical/MOM_CVMix_ddiff.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-97> (0)
- *M* src/parameterizations/vertical/MOM_CVMix_shear.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-98> (0)
- *M* src/parameterizations/vertical/MOM_bkgnd_mixing.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-99> (0)
- *M* src/parameterizations/vertical/MOM_bulk_mixed_layer.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-100> (0)
- *M* src/parameterizations/vertical/MOM_diabatic_aux.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-101> (0)
- *M* src/parameterizations/vertical/MOM_diabatic_driver.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-102> (0)
- *M* src/parameterizations/vertical/MOM_diapyc_energy_req.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-103> (0)
- *M* src/parameterizations/vertical/MOM_energetic_PBL.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-104> (0)
- *M* src/parameterizations/vertical/MOM_entrain_diffusive.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-105> (0)
- *M* src/parameterizations/vertical/MOM_geothermal.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-106> (0)
- *M* src/parameterizations/vertical/MOM_internal_tide_input.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-107> (0)
- *M* src/parameterizations/vertical/MOM_kappa_shear.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-108> (0)
- *M* src/parameterizations/vertical/MOM_opacity.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-109> (0)
- *M* src/parameterizations/vertical/MOM_set_diffusivity.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-110> (0)
- *M* src/parameterizations/vertical/MOM_set_viscosity.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-111> (0)
- *D* src/parameterizations/vertical/MOM_shortwave_abs.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-112> (0)
- *M* src/parameterizations/vertical/MOM_tidal_mixing.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-113> (0)
- *M* src/parameterizations/vertical/MOM_vert_friction.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-114> (0)
- *M* src/tracer/MOM_OCMIP2_CFC.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-115> (0)
- *M* src/tracer/MOM_generic_tracer.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-116> (0)
- *M* src/tracer/MOM_neutral_diffusion.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-117> (0)
- *M* src/tracer/MOM_offline_aux.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-118> (0)
- *M* src/tracer/MOM_offline_main.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-119> (0)
- *M* src/tracer/MOM_tracer_advect.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-120> (0)
- *M* src/tracer/MOM_tracer_hor_diff.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-121> (0)
- *M* src/tracer/MOM_tracer_registry.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-122> (0)
- *M* src/tracer/advection_test_tracer.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-123> (0)
- *M* src/tracer/boundary_impulse_tracer.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-124> (0)
- *M* src/tracer/dye_example.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-125> (0)
- *M* src/tracer/ideal_age_example.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-126> (0)
- *M* src/tracer/oil_tracer.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-127> (0)
- *M* src/tracer/pseudo_salt_tracer.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-128> (0)
- *M* src/tracer/tracer_example.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-129> (0)
- *M* src/user/BFB_initialization.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-130> (0)
- *M* src/user/BFB_surface_forcing.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-131> (0)
- *M* src/user/DOME2d_initialization.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-132> (0)
- *M* src/user/DOME_initialization.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-133> (0)
- *M* src/user/ISOMIP_initialization.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-134> (0)
- *M* src/user/Idealized_Hurricane.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-135> (0)
- *M* src/user/Kelvin_initialization.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-136> (0)
- *M* src/user/MOM_controlled_forcing.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-137> (0)
- *M* src/user/MOM_wave_interface.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-138> (0)
- *M* src/user/Phillips_initialization.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-139> (0)
- *M* src/user/RGC_initialization.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-140> (0)
- *M* src/user/Rossby_front_2d_initialization.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-141> (0)
- *M* src/user/SCM_CVMix_tests.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-142> (0)
- *M* src/user/dumbbell_surface_forcing.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-143> (0)
- *M* src/user/dyed_channel_initialization.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-144> (0)
- *M* src/user/shelfwave_initialization.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-145> (0)
- *M* src/user/soliton_initialization.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-146> (0)
- *M* src/user/supercritical_initialization.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-147> (0)
- *M* src/user/tidal_bay_initialization.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-148> (0)
- *M* src/user/user_initialization.F90
<https://github.com/NOAA-GFDL/MOM6/pull/988/files#diff-149> (0)
Patch Links:
- https://github.com/NOAA-GFDL/MOM6/pull/988.patch
- https://github.com/NOAA-GFDL/MOM6/pull/988.diff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/NOAA-GFDL/MOM6/pull/988?email_source=notifications&email_token=ADMGAS4NWHGAPAKXSMIUUMTQHFS4FA5CNFSM4ISQEN4KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HIQQSQA>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADMGAS2YAHSJ44ZU2QMTWP3QHFS4FANCNFSM4ISQEN4A>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR submits everything on dev/gfdl as of 2019/08-30 to dev/master. As per usual feedback from @gustavo-marques, @awallcraft, @kshedstrom and @jiandewang is asked for before we accept this PR.
Main features:
There are no answer changes implied for the MOM6-examples configurations but because of new parameters a branch with the same name has been pushed to https://github.com/NOAA-GFDL/MOM6-examples/tree/dev-master-candidate-2019-08-30.