Partial solution to non-unity H_TO_M in Boussinesq cases #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected the scale conversion factor for pbce from H_to_m to m_to_H in a chksum call. Also corrected the units of pbce in several comments. This does change a set of diagnostic messages when DEBUG=True and H_TO_M is not 1, but all test cases are bitwise identical.
Added chksum calls for h_u and h_v if they are present as arguments to btcalc. All answers are bitwise identical.
GV%Angstrom was intended to be a very thin thickness in the same units (H) as the other thicknesses, but this conversion was not being done for Boussinesq test cases. Several test cases (e.g., double_gyre) that had previously changed answers when H_TO_M was not set to 1 now give the same answers when the value of H_TO_M is varied by a factor of integer powers of 2. Answers in test cases are unchanged.
nikizadehgfdl
pushed a commit
to nikizadehgfdl/MOM6
that referenced
this pull request
Oct 9, 2017
- Round-off changes due to symmetry-dix in bracketing. - Changes answers for many experiments. - NOAA-GFDL/MOM@cec7499 Merge branch 'nicjhan-531-transform-bracketing-fix' into dev/gfdl - NOAA-GFDL/MOM@e2cdbb3 Merge branch '531-transform-bracketing-fix' of https://github.com/nicjhan/MOM6 into nicjhan-531-transform-bracketing-fix - NOAA-GFDL/MOM@c8d3ac0 Merge pull request mom-ocean#549 from Hallberg-NOAA/dev/gfdl - NOAA-GFDL/MOM@e344fb9 Merge branch 'dev/gfdl' of github.com:NOAA-GFDL/MOM6 into dev/gfdl - NOAA-GFDL/MOM@ea1a338 Merge pull request mom-ocean#548 from breichl/user/bgr/Fix_BuoyFlux_merged - NOAA-GFDL/MOM@0f5a5ed (*)close_param_file always closes the input files - NOAA-GFDL/MOM@da325d6 Merge pull request mom-ocean#547 from CarolineCardinale/dev/gfdl - NOAA-GFDL/MOM@7756722 Merge pull request mom-ocean#546 from Hallberg-NOAA/dev/gfdl - NOAA-GFDL/MOM@8a5704d Add missing comment to MOM_forcing_type.F90 - NOAA-GFDL/MOM@1bdfa54 Merge branch 'dev/gfdl' into user/bgr/Fix_BuoyFlux_merged - NOAA-GFDL/MOM@94c1735 Added Doxygen Comments - NOAA-GFDL/MOM@0357baa (*)Convert GV%Angstrom to units of H - NOAA-GFDL/MOM@c0e00a4 Added chksum calls for h_u and h_v in btcalc - NOAA-GFDL/MOM@d4999e3 Corrected the chksum scaling for pbce - NOAA-GFDL/MOM@3d1d9c0 Merge branch 'user/bgr/BuoyFluxFix' into user/bgr/Fix_BuoyFlux_merged - NOAA-GFDL/MOM@eaefd55 Remove apostrophe from comments in MOM_forcing_type.F90 - NOAA-GFDL/MOM@7c0b9a2 Adding code changes that are part of previous commit. - NOAA-GFDL/MOM@9bd84c2 Code fix to remove 2nd call to extractfluxes1d when using ePBL. - NOAA-GFDL/MOM@10e5fc2 Bracketing fix for transform test. Changes answers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request allows several of the Boussinesq test cases to give identical answers when H_TO_M is changed. All existing test cases (which use H_TO_M=1) are bitwise identical.