FMS1: Don't create IO domains for single-PE domain #1522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1522 +/- ##
============================================
- Coverage 29.09% 29.09% -0.01%
============================================
Files 239 239
Lines 71566 71567 +1
============================================
- Hits 20825 20824 -1
- Misses 50741 50743 +2
Continue to review full report at Codecov.
|
FMS mpp domain creation is done in the `clone_MD_to_d2D` function, and currently an IO domain is always created within the MPP domain. This has caused problems with single-PE runs in FMS1, where the `write_field` logic was not able to reach the part which removes halo data if an IO domain was present, and halo data was being written to the restart files. This issue arose when `PARALLEL_RESTARTFILES` was set to `True` for single-PE tests. This does not appear to be a problem with FMS2, and no action is needed by the FMS team.
marshallward
force-pushed
the
no_1pe_io_layout
branch
from
e1bccb4
to
8e5a1b7
Compare
|
oops accidentally closed this |
Hallberg-NOAA
approved these changes
Oct 25, 2021
There was a problem hiding this comment.
The logic behind this PR is sound, and it should be merged in as it has now passed both TC testing and pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/13911.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FMS mpp domain creation is done in the
clone_MD_to_d2Dfunction, andcurrently an IO domain is always created within the MPP domain.
This has caused problems with single-PE runs in FMS1, where the
write_fieldlogic was not able to reach the part which removes halodata if an IO domain was present, and halo data was being written to the
restart files.
This issue arose when
PARALLEL_RESTARTFILESwas set toTrueforsingle-PE tests.
This does not appear to be a problem with FMS2, and no action is needed
by the FMS team.