Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to prescribe internal wave generation site in grid indices, fixes #1149 #1448

Merged
merged 4 commits into from
Aug 11, 2021

Conversation

raphaeldussin
Copy link
Contributor

comparing with longitude/latitude does not allow to specify accurately the source of internal wave generation.
the new logical flag allows to pick a point using global indices. The former option is kept for now but could be phased out
later.

@Hallberg-NOAA Hallberg-NOAA linked an issue Jul 26, 2021 that may be closed by this pull request
Copy link
Collaborator

@Hallberg-NOAA Hallberg-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this is a case where slight code changes to improve the error checking on the use of the new parameters (see the specific suggestions in a separate comment) could save some user a lot of grief in the future. @raphaeldussin, please feel free to rebut this suggestion if you think it is more effort than it is worth. Otherwise this PR looks like it will be a useful addition.

@codecov
Copy link

codecov bot commented Aug 9, 2021

Codecov Report

Merging #1448 (b8a2926) into dev/gfdl (7883f63) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head b8a2926 differs from pull request most recent head aabd67e. Consider uploading reports for the commit aabd67e to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##           dev/gfdl    #1448      +/-   ##
============================================
- Coverage     29.13%   29.13%   -0.01%     
============================================
  Files           235      235              
  Lines         71025    71039      +14     
============================================
  Hits          20694    20694              
- Misses        50331    50345      +14     
Impacted Files Coverage Δ
...meterizations/vertical/MOM_internal_tide_input.F90 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7883f63...aabd67e. Read the comment docs.

@raphaeldussin
Copy link
Contributor Author

@Hallberg-NOAA the last changes implement the proposed improvements. ready to merge on my end

@Hallberg-NOAA
Copy link
Collaborator

I think that there should be one more minor addition to this PR. There is a test to see if the (x,y) test source locations are being set and CS%int_tide_use_glob_ij == .true., and that test looks perfect, but I think that there should also be a test to see if the (i,j) test source locations are being set and CS%int_tide_use_glob_ij == .false..

@raphaeldussin
Copy link
Contributor Author

agreed! and added!

@marshallward
Copy link
Collaborator

marshallward commented Aug 11, 2021

Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/13332 ✔️

@marshallward marshallward merged commit 77175fe into mom-ocean:dev/gfdl Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nitpicking on internal tides source test
3 participants