-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add option to prescribe internal wave generation site in grid indices, fixes #1149 #1448
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this is a case where slight code changes to improve the error checking on the use of the new parameters (see the specific suggestions in a separate comment) could save some user a lot of grief in the future. @raphaeldussin, please feel free to rebut this suggestion if you think it is more effort than it is worth. Otherwise this PR looks like it will be a useful addition.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1448 +/- ##
============================================
- Coverage 29.13% 29.13% -0.01%
============================================
Files 235 235
Lines 71025 71039 +14
============================================
Hits 20694 20694
- Misses 50331 50345 +14
Continue to review full report at Codecov.
|
@Hallberg-NOAA the last changes implement the proposed improvements. ready to merge on my end |
I think that there should be one more minor addition to this PR. There is a test to see if the (x,y) test source locations are being set and |
agreed! and added! |
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/13332 ✔️ |
comparing with longitude/latitude does not allow to specify accurately the source of internal wave generation.
the new logical flag allows to pick a point using global indices. The former option is kept for now but could be phased out
later.