Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ale sponge fix 022321 #1333

Conversation

MJHarrison-GFDL
Copy link
Contributor

No description provided.

	- this addresses a bug in the apply_ALE_sponge routine which
  	had been passing zero values to the remapping routine for the
	target grid thicknesses.
@codecov
Copy link

codecov bot commented Feb 23, 2021

Codecov Report

Merging #1333 (4a6664b) into dev-gfdl-main-candidate-2021-02-19 (45b3366) will increase coverage by 0.00%.
The diff coverage is 75.00%.

Impacted file tree graph

@@                         Coverage Diff                         @@
##           dev-gfdl-main-candidate-2021-02-19    #1333   +/-   ##
===================================================================
  Coverage                               45.74%   45.75%           
===================================================================
  Files                                     234      234           
  Lines                                   72540    72542    +2     
===================================================================
+ Hits                                    33187    33189    +2     
  Misses                                  39353    39353           
Impacted Files Coverage Δ
src/parameterizations/vertical/MOM_ALE_sponge.F90 26.81% <75.00%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45b3366...9048966. Read the comment docs.

@marshallward
Copy link
Collaborator

marshallward commented Feb 23, 2021

https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/12106 ✔️

(for dev/gfdl/ but otherwise identical)

@marshallward
Copy link
Collaborator

This passed, thank you @MJHarrison-GFDL

@marshallward marshallward merged commit daee0bb into mom-ocean:dev-gfdl-main-candidate-2021-02-19 Feb 23, 2021
@MJHarrison-GFDL MJHarrison-GFDL deleted the ALE_sponge_fix_022321 branch April 10, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants