Nuopc api test #1292
Merged
Nuopc api test #1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allows us to check that we have not broken the ability to compile with the NUOPC, MCT or coupled_driver modules. - This is not a complete compile but only upto the last module that does not need anything other than MOM6 objects.
- Following suggestion from @marshallward I've implemented an option to select the driver code at the configure stage (changes to configure.ac) - This allows the target build/coupled/ocean_model_MOM.o to be built using the .testing ac tools.
- Checks that MOM6 can be compiled with the various coupled drivers.
- We spent 1 minute build symmetric unnecessarily when checking the coupled APIs
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1292 +/- ##
============================================
- Coverage 45.88% 45.82% -0.07%
============================================
Files 225 227 +2
Lines 71396 71552 +156
============================================
+ Hits 32763 32791 +28
- Misses 38633 38761 +128
Continue to review full report at Codecov.
|
|
To the surprise of no one, this PR passed the MOM6 pipeline testing at https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/11882. |
Hallberg-NOAA
approved these changes
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--with-driver=<path_to_driver>and new targets (e.g. check_mom6_api_nuopc, check_mom6_api_coupled) to.testing/Makefileto facilitate the above.