+Add option to fix z-file layer initialization bug #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new runtime flag, LAYER_Z_INIT_IC_EXTRAP_BUG, to allow for the correction of a vertical indexing bug when initializing a layer-mode configuration from a Z-space temperature and salinity file with nominally unstable density profiles in the bottommost points in the z-space file. Also corrected some spelling errors in MOM_state_initialization.F90. By default, all solutions are bitwise identical, but there is a new entry in some MOM_parameter_doc files.
adcroft
approved these changes
Dec 4, 2020
|
I assume this would have affected CM2G63L initial conditions? Might explain that initial bottom warming Toni asked us about... |
adcroft
requested changes
Dec 4, 2020
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1266 +/- ##
============================================
- Coverage 45.78% 45.78% -0.01%
============================================
Files 225 225
Lines 71455 71458 +3
============================================
Hits 32714 32714
- Misses 38741 38744 +3
Continue to review full report at Codecov.
|
marshallward
approved these changes
Dec 10, 2020
adcroft
approved these changes
Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new runtime flag, LAYER_Z_INIT_IC_EXTRAP_BUG, to allow for the
correction of a vertical indexing bug when initializing a layer-mode
configuration from a Z-space temperature and salinity file with nominally
unstable density profiles in the bottommost points in the z-space file. Also
corrected some spelling errors in MOM_state_initialization.F90. By default, all
solutions are bitwise identical, but there is a new entry in some
MOM_parameter_doc files.