Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sponges don't work in adiabatic configurations; enhance docstrings? #1417

Closed
navidcy opened this issue Jun 4, 2021 · 0 comments · Fixed by #1438
Closed

sponges don't work in adiabatic configurations; enhance docstrings? #1417

navidcy opened this issue Jun 4, 2021 · 0 comments · Fixed by #1438

Comments

@navidcy
Copy link
Contributor

navidcy commented Jun 4, 2021

We've been trying to set up an idealised configuration in isopycnal coordinates with sponges. After lots of trial and error and with the detective skills of @angus-g we (re)discovered that ADIABATIC=TRUE won't allow sponges.

Retrospectively, it makes sense. But perhaps enhancing the docstring a bit to explicitly say that sponges only work in adiabatic configurations would be good?
@navidcy navidcy changed the title sponges sponges don't work in adiabatic configurations; enhance docstrings? Jun 4, 2021
Hallberg-NOAA added a commit to Hallberg-NOAA/MOM6 that referenced this issue Jul 2, 2021
@Hallberg-NOAA
Flag inconsistent parameters if ADIABATIC = True
d4305c3 
  Add checks for inconsistent parameter settings in adiabatic_driver_init() when
ADIABATIC = True, and issue instructive error messages if any are found.  This
PR addresses MOM6 issue mom-ocean#1417.  All answers are bitwise identical, although some
cases where the inconsistent parameter settings were previously ignored may now
issue fatal errors and will not run.
@Hallberg-NOAA Hallberg-NOAA mentioned this issue Jul 2, 2021
Merged
@Hallberg-NOAA Hallberg-NOAA linked a pull request Jul 9, 2021 that will close this issue
Flag inconsistent parameters if ADIABATIC = True #1438
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Flag inconsistent parameters if ADIABATIC = True Hallberg-NOAA/MOM6
1 participant
@navidcy