Skip to content

Commit

Permalink
Testing: Disable 2018 answer flags
Browse files Browse the repository at this point in the history
The TC tests are still using 2018 answer reproducibility flags, which
fail when aggressive initialization of allocatable arrays is enabled.
In at least one case, the `mask_z` variable of the ALE sponge is
incompletely initialized when `DEFAULT_2018_ANSWERS` is set.  When
unset, the array is fully initialized.

This patch disables the 2018 answer flags and restores reproducibility
on such platforms.
  • Loading branch information
marshallward committed Aug 27, 2021
1 parent 90af3cb commit f347b10
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 5 deletions.
1 change: 0 additions & 1 deletion .testing/tc0/MOM_input
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,6 @@ ENERGYSAVEDAYS = 1.0

DIAG_AS_CHKSUM = True
DEBUG = True
DEFAULT_2018_ANSWERS = True ! [Boolean] default = True
GRID_ROTATION_ANGLE_BUGS = True ! [Boolean] default = True
USE_GM_WORK_BUG = True ! [Boolean] default = True
FIX_UNSPLIT_DT_VISC_BUG = False ! [Boolean] default = False
Expand Down
1 change: 0 additions & 1 deletion .testing/tc1/MOM_input
Original file line number Diff line number Diff line change
Expand Up @@ -575,7 +575,6 @@ ENERGYSAVEDAYS = 0.125 ! [days] default = 3600.0
DIAG_AS_CHKSUM = True
DEBUG = True
USE_PSURF_IN_EOS = False ! [Boolean] default = False
DEFAULT_2018_ANSWERS = True ! [Boolean] default = True
GRID_ROTATION_ANGLE_BUGS = True ! [Boolean] default = True
INTERPOLATE_RES_FN = True ! [Boolean] default = True
GILL_EQUATORIAL_LD = False ! [Boolean] default = False
Expand Down
1 change: 0 additions & 1 deletion .testing/tc2/MOM_input
Original file line number Diff line number Diff line change
Expand Up @@ -610,7 +610,6 @@ DIAG_AS_CHKSUM = True
DEBUG = True
USE_GM_WORK_BUG = False
USE_PSURF_IN_EOS = False ! [Boolean] default = False
DEFAULT_2018_ANSWERS = True ! [Boolean] default = True
GRID_ROTATION_ANGLE_BUGS = True ! [Boolean] default = True
REMAP_UV_USING_OLD_ALG = True ! [Boolean] default = True
USE_LAND_MASK_FOR_HVISC = False ! [Boolean] default = False
Expand Down
1 change: 0 additions & 1 deletion .testing/tc3/MOM_input
Original file line number Diff line number Diff line change
Expand Up @@ -469,7 +469,6 @@ ENERGYSAVEDAYS = 3.0 ! [hours] default = 1.44E+04
! energies of the run and other globally summed diagnostics.
DIAG_AS_CHKSUM = True
DEBUG = True
DEFAULT_2018_ANSWERS = True ! [Boolean] default = True
OBC_RADIATION_MAX = 10.0 ! [nondim] default = 10.0
GRID_ROTATION_ANGLE_BUGS = True ! [Boolean] default = True
USE_GM_WORK_BUG = True ! [Boolean] default = True
Expand Down
1 change: 0 additions & 1 deletion .testing/tc4/MOM_input
Original file line number Diff line number Diff line change
Expand Up @@ -409,7 +409,6 @@ DIAG_AS_CHKSUM = True
DEBUG = True

USE_PSURF_IN_EOS = False ! [Boolean] default = False
DEFAULT_2018_ANSWERS = True ! [Boolean] default = True
GRID_ROTATION_ANGLE_BUGS = True ! [Boolean] default = True
INTERPOLATE_RES_FN = True ! [Boolean] default = True
GILL_EQUATORIAL_LD = False ! [Boolean] default = False
Expand Down

0 comments on commit f347b10

Please sign in to comment.