Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove config default value #1369

Closed
jberger opened this issue Jun 20, 2019 · 3 comments
Closed

Remove config default value #1369

jberger opened this issue Jun 20, 2019 · 3 comments
Milestone

Comments

@jberger
Copy link
Member

jberger commented Jun 20, 2019

Having a stash default "config" which pointed to the app's config was a backcompat measure ages ago. Most users use the config helper now. It is awkward that the default is only loaded by the config loader plugins and makes for unexpected action-at-a-distance since that default does not exist if you load configuration in other ways. It should be removed in favor of the config helper and/or app accessor.

Mitigations for affected users:
Users are encouraged to switch to using config in templates rather than $config. Projects wishing to keep the existing behavior may implement the default in the project themselves by adding $app->defaults(config => $app->config); to the application startup after loading their configuration.

@kraih
Copy link
Member

kraih commented Jun 20, 2019

Deprecation is now in effect. baf97a0...917d61d

@kraih kraih added this to the 9.0 milestone Oct 15, 2019
@kraih
Copy link
Member

kraih commented Dec 8, 2020

This is a test comment to see if linking to a discussion like #1625 works.

@kraih
Copy link
Member

kraih commented Feb 10, 2021

Done, as part of the 9.0 branch.

@kraih kraih closed this as completed Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants