Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX-#7277: Remove Cudf storage format as unmaintained #7290

Merged
merged 1 commit into from
May 29, 2024

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented May 28, 2024

What do these changes do?

@devin-petersohn what do you think? If necessary (or as we allocate resources for this), we can return it.

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Remove Cudf storage format as unmaintained #7277
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
Copy link
Collaborator

@devin-petersohn devin-petersohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nobody is using it right now, and we aren't testing it so I am sure it doesn't work. Let's remove @anmyachev

@anmyachev anmyachev merged commit 002125b into modin-project:main May 29, 2024
52 checks passed
@anmyachev anmyachev deleted the issue7277 branch May 29, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Cudf storage format as unmaintained
2 participants