Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PERF-#7227: Call modin_frame.combine() for merge and join only when necessary #7228

Merged
merged 1 commit into from
Apr 27, 2024

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Apr 27, 2024

What do these changes do?

We should not call combine for cases where the calculations default to pandas, since the result of this function is not used.

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Do right._modin_frame.combine() for merge and join only when necessary #7227
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

…oin only when necessary

Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev anmyachev marked this pull request as ready for review April 27, 2024 10:02
@YarShev YarShev merged commit 5b96219 into modin-project:main Apr 27, 2024
38 checks passed
@anmyachev anmyachev deleted the issue7227 branch April 27, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do right._modin_frame.combine() for merge and join only when necessary
2 participants