Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-#6352: Fix the HdkOnNativeDataframePartition._width_cache property computation #6353

Merged
merged 1 commit into from
Jul 4, 2023
Merged

FIX-#6352: Fix the HdkOnNativeDataframePartition._width_cache property computation #6353

merged 1 commit into from
Jul 4, 2023

Conversation

AndreyPavlenko
Copy link
Collaborator

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves The HdkOnNativeDataframePartition._width_cache property computation is not valid #6352
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@AndreyPavlenko AndreyPavlenko requested review from a team as code owners July 4, 2023 12:10
@AndreyPavlenko
FIX-modin-project#6352: Fixed the HdkOnNativeDataframePartition._widt…
9cfca7c 
…h_cache property computation

Signed-off-by: Andrey Pavlenko <andrey.a.pavlenko@gmail.com>
@AndreyPavlenko AndreyPavlenko mentioned this pull request Jul 4, 2023
Merged
6 tasks
@YarShev YarShev changed the title FIX-#6352: Fixed the HdkOnNativeDataframePartition._width_cache property computation FIX-#6352: Fix the HdkOnNativeDataframePartition._width_cache property computation Jul 4, 2023
@YarShev YarShev merged commit b45054b into modin-project:master Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YarShev YarShev YarShev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The HdkOnNativeDataframePartition._width_cache property computation is not valid
2 participants
@AndreyPavlenko @YarShev