Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REFACTOR-#6065: Use between_time in at_time #6158

Merged
merged 2 commits into from
May 18, 2023
Merged

REFACTOR-#6065: Use between_time in at_time #6158

merged 2 commits into from
May 18, 2023

Conversation

vnlitvinov
Copy link
Collaborator

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves REFACTOR: Use between_time in at_time #6065
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

mvashishtha and others added 2 commits May 18, 2023 18:08
@mvashishtha @vnlitvinov
REFACTOR-modin-project#6065: Use between_time in at_time
553a5d5 
Co-authored-by: mvashishtha <mahesh@ponder.io>
Signed-off-by: Vasily Litvinov <fam1ly.n4me@yandex.ru>
@vnlitvinov
Fix linting
15c5afa
@mvashishtha mvashishtha marked this pull request as ready for review May 18, 2023 15:17
@mvashishtha mvashishtha requested a review from a team as a code owner May 18, 2023 15:17
@mvashishtha mvashishtha merged commit f96454c into modin-project:master May 18, 2023
@vnlitvinov vnlitvinov deleted the use-between-time branch May 19, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvashishtha mvashishtha mvashishtha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

REFACTOR: Use between_time in at_time
2 participants
@vnlitvinov @mvashishtha