-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REFACTOR-#6044: remove code duplication for get_objects_from_partitions
#6045
Conversation
…_from_partitions' Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
""" | ||
if hasattr(cls, "_execution_wrapper"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if hasattr(cls, "_execution_wrapper"): | |
if hasattr(cls._partition_class, "execution_wrapper"): |
Would this work? I am just thinking it would good for one class to keep the execution wrapper.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really like that kind of thing. In the code below, we will materialize multiple partitions, and it will look a little strange that to materialize multiple partitions, we use the attribute of the partition, and not the manager, which is designed to work with multiple partitions.
On the other hand, all wrappers are implemented as mixins, so we can switch to inheritance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the other hand, all wrappers are implemented as mixins, so we can switch to inheritance.
We should probably give it a try.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we wait for #6052 in order to avoid double refactoring commits?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to merge it without waiting. Making these changes is faster than having to wait for the CI for this PR to complete again.
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
git commit -s
get_objects_from_partitions
#6044docs/development/architecture.rst
is up-to-date