Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-#5934: Enable test_window test on the HDK engine and add to ci #5935

Merged
merged 4 commits into from
Apr 5, 2023
Merged

FIX-#5934: Enable test_window test on the HDK engine and add to ci #5935

merged 4 commits into from
Apr 5, 2023

Conversation

AndreyPavlenko
Copy link
Collaborator

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Enable test_window test on the HDK engine and add to ci #5934
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@AndreyPavlenko AndreyPavlenko requested review from a team as code owners April 3, 2023 20:40
dchigarev
dchigarev reviewed Apr 4, 2023
View reviewed changes
Copy link
Collaborator

@dchigarev dchigarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

modin/experimental/core/execution/native/implementations/hdk_on_native/calcite_serializer.py Outdated Show resolved Hide resolved
@AndreyPavlenko
FIX-modin-project#5934: Enable test_window test on the HDK engine and…
9f68977 
… add to ci

Signed-off-by: Andrey Pavlenko <andrey.a.pavlenko@gmail.com>
@AndreyPavlenko
Use pandas.isna()
39b68b6
anmyachev
anmyachev approved these changes Apr 5, 2023
View reviewed changes
Copy link
Collaborator

@anmyachev anmyachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anmyachev anmyachev merged commit f4bcefe into modin-project:master Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ienkovich ienkovich ienkovich left review comments

@dchigarev dchigarev dchigarev left review comments

@anmyachev anmyachev anmyachev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable test_window test on the HDK engine and add to ci
4 participants
@AndreyPavlenko @ienkovich @anmyachev @dchigarev