REFACTOR-#5874: move lazy_metadata_decorator into utils.py
#5872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://github.com/avatars/in/57789?s=60&v=4){kind=small}
Comment on lines
+41
to
+44
| from modin.core.dataframe.pandas.dataframe.utils import ( | ||
| build_sort_functions, | ||
| lazy_metadata_decorator, | ||
| ) |
Check notice
Code scanning / CodeQL
Cyclic import
|
|
||
| @wraps(f) | ||
| def run_f_on_minimally_updated_metadata(self, *args, **kwargs): | ||
| from .dataframe import PandasDataframe |
Check notice
Code scanning / CodeQL
Cyclic import
anmyachev
changed the title
lazy_metadata_decorator into utils.py
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
anmyachev
force-pushed
the
move-lazy_metadata_decorator
branch
from
a25eab0
to
342eae3
Compare
mvashishtha
previously approved these changes
Mar 29, 2023
mvashishtha
approved these changes
Mar 30, 2023
YarShev
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
dataframe.pyfile is very large and the decorator is very easy to move.flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -slazy_metadata_decoratorintoutils.py#5874docs/development/architecture.rstis up-to-date