Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-#5597: Pin sqlalchemy<1.4.46 as pandas does to fix CI #5593

Merged
merged 1 commit into from
Jan 30, 2023
Merged

FIX-#5597: Pin sqlalchemy<1.4.46 as pandas does to fix CI #5593

merged 1 commit into from
Jan 30, 2023

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Jan 28, 2023 •
edited
Loading

Signed-off-by: Anatoly Myachev anatoly.myachev@intel.com

What do these changes do?

pandas-dev/pandas#50591

Failed CI: https://github.com/modin-project/modin/actions/runs/4028379793/jobs/6930652236

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves CI that run on master branch is failed due to new release of sqlalchemy==2.0.0 #5597
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@anmyachev
FIX-#0000: pin sqlalchemy<1.4.46 as pandas does to fix CI
0d105ed 
Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
@anmyachev anmyachev changed the title FIX-#0000: pin sqlalchemy<1.4.46 as pandas does to fix CI FIX-#5597: Pin sqlalchemy<1.4.46 as pandas does to fix CI Jan 30, 2023
@anmyachev anmyachev marked this pull request as ready for review January 30, 2023 14:04
@anmyachev anmyachev requested a review from a team as a code owner January 30, 2023 14:04
anmyachev
anmyachev commented Jan 30, 2023
View reviewed changes
requirements/env_hdk.yml
@@ -17,7 +17,7 @@ dependencies:
- psutil
- openpyxl
- xlrd
- sqlalchemy
- sqlalchemy>=1.4.0,<1.4.46
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a minimal border here to keep this aligned with the rest of the environments.

@dchigarev dchigarev merged commit 5d1fe8b into modin-project:master Jan 30, 2023
@anmyachev anmyachev deleted the pin-sqlalchemy branch August 31, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchigarev dchigarev dchigarev approved these changes

Assignees
No one assigned
Labels
Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI that run on master branch is failed due to new release of sqlalchemy==2.0.0
2 participants
@anmyachev @dchigarev