Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-#5187: Fixed RecursionError in OmnisciLaunchParameters.get() #5199

Merged
merged 1 commit into from
Nov 18, 2022
Merged

FIX-#5187: Fixed RecursionError in OmnisciLaunchParameters.get() #5199

merged 1 commit into from
Nov 18, 2022

Conversation

AndreyPavlenko
Copy link
Collaborator

Signed-off-by: Andrey Pavlenko andrey.a.pavlenko@gmail.com

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves BUG: OmnisciLaunchParameters.get() throws RecursionError: maximum recursion depth exceeded in comparison #5187
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@AndreyPavlenko
FIX-modin-project#5187: Fixed RecursionError in OmnisciLaunchParamete…
428270e 
…rs.get()

Signed-off-by: Andrey Pavlenko <andrey.a.pavlenko@gmail.com>
@AndreyPavlenko AndreyPavlenko marked this pull request as ready for review November 7, 2022 19:27
@AndreyPavlenko AndreyPavlenko requested a review from a team as a code owner November 7, 2022 19:27
vnlitvinov
vnlitvinov approved these changes Nov 18, 2022
View reviewed changes
Copy link
Collaborator

@vnlitvinov vnlitvinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vnlitvinov vnlitvinov merged commit c51ab40 into modin-project:master Nov 18, 2022
dchigarev pushed a commit that referenced this pull request Nov 25, 2022
@AndreyPavlenko @dchigarev
FIX-#5187: Fixed RecursionError in OmnisciLaunchParameters.get() (#5199)
28a16a8 
Signed-off-by: Andrey Pavlenko <andrey.a.pavlenko@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vnlitvinov vnlitvinov vnlitvinov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: OmnisciLaunchParameters.get() throws RecursionError: maximum recursion depth exceeded in comparison
2 participants
@AndreyPavlenko @vnlitvinov