-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX-#5171: Allow xgboost >= 1.7.0. #5195
FIX-#5171: Allow xgboost >= 1.7.0. #5195
Conversation
Signed-off-by: mvashishtha <mahesh@ponder.io>
Signed-off-by: mvashishtha <mahesh@ponder.io>
7ad4afb
to
5853aad
Compare
- xgboost>=1.6.0,<1.7.0 | ||
# TODO(https://github.com/modin-project/modin/issues/5194): Uncap xgboost | ||
# when we use collective instead of rabit. | ||
- xgboost>=1.7.1,<2.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vnlitvinov should we add the same pins for xgboost in env_hdk.yml
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea as I don't have anything to do with HDK anymore, but I would like to have our requirements be as consistent as possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the same requirement for hdk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mvashishtha let's fix all .yml
and .txt
files, I think env_hdk.yml
(and maybe requirements-doc.txt
, not sure about that tho as it doesn't pin any version in it) is still missing.
Signed-off-by: mvashishtha <mahesh@ponder.io>
@vnlitvinov I've added env_hdk and requirements-doc pins even though those don't pin xgboost already. Also we seem to support xgboost on ray only and it's not clear to me that hdk even uses xgboost. Anyway, everything that requires xgboost now specifies the same versions. |
@vnlitvinov up to you |
Signed-off-by: mvashishtha mahesh@ponder.io
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
git commit -s
docs/development/architecture.rst
is up-to-date