Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX-#5171: Allow xgboost >= 1.7.0. #5195

Merged

Conversation

mvashishtha
Copy link
Collaborator

Signed-off-by: mvashishtha mahesh@ponder.io

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves TEST: CI: test_xgboost 1.7 on test-ubuntu[ray] is getting stuck #5171
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@mvashishtha mvashishtha requested a review from a team as a code owner November 4, 2022 19:23
pyrito
pyrito previously approved these changes Nov 4, 2022
requirements-dev.txt Outdated Show resolved Hide resolved
environment-dev.yml Show resolved Hide resolved
mvashishtha added 2 commits November 9, 2022 15:02
Signed-off-by: mvashishtha <mahesh@ponder.io>
Signed-off-by: mvashishtha <mahesh@ponder.io>
- xgboost>=1.6.0,<1.7.0
# TODO(https://github.com/modin-project/modin/issues/5194): Uncap xgboost
# when we use collective instead of rabit.
- xgboost>=1.7.1,<2.0.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vnlitvinov should we add the same pins for xgboost in env_hdk.yml?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea as I don't have anything to do with HDK anymore, but I would like to have our requirements be as consistent as possible.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the same requirement for hdk

Copy link
Collaborator

@vnlitvinov vnlitvinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mvashishtha let's fix all .yml and .txt files, I think env_hdk.yml (and maybe requirements-doc.txt, not sure about that tho as it doesn't pin any version in it) is still missing.

Signed-off-by: mvashishtha <mahesh@ponder.io>
@mvashishtha
Copy link
Collaborator Author

@vnlitvinov I've added env_hdk and requirements-doc pins even though those don't pin xgboost already. Also we seem to support xgboost on ray only and it's not clear to me that hdk even uses xgboost. Anyway, everything that requires xgboost now specifies the same versions.

@anmyachev
Copy link
Collaborator

@vnlitvinov up to you

@vnlitvinov vnlitvinov merged commit d80a458 into modin-project:master Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TEST: CI: test_xgboost 1.7 on test-ubuntu[ray] is getting stuck
4 participants