-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TEST-#5172: Add fuzzydata logs to artifacts #5173
Conversation
Signed-off-by: Suhail Rehman <suhailrehman@gmail.com>
Based on input from @mvashishtha, adding a few more quality-of-life improvements to this PR. |
Signed-off-by: Suhail Rehman <suhailrehman@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@suhailrehman thanks! LGTM! @mvashishtha it's up to you
Sample logs from an info failure LGTM (this is from devin-petersohn's commit 42ddd1a780c03094f2c9624c9edb88553574e824 on his fork of modin): Command:
Failure: failure logs================================================================= test session starts ================================================================== modin/experimental/fuzzydata/test/test_fuzzydata.py F [100%]CoverageWarning: Couldn't parse '/Users/maheshvashishtha/software_sources/modin/modin/core/execution/container.py': No source for code: '/Users/maheshvashishtha/software_sources/modin/modin/core/execution/container.py'. (couldnt-parse) ======================================================================= FAILURES =======================================================================
modin/experimental/fuzzydata/test/test_fuzzydata.py:46: ../../opt/anaconda3/envs/modin-dev/lib/python3.10/site-packages/fuzzydata/core/generator.py:379: in generate_workflow cls = <class 'modin.error_message.ErrorMessage'>, failure_condition = True, extra_log = 'Internal and external indices on axis 0 do not match.'
E Exception: Internal Error. Please visit https://github.com/modin-project/modin/issues to file an issue with the traceback and the command that caused this error. If you can't file a GitHub issue, please email bug_reports@modin.org. modin/error_message.py:80: Exception ---------- coverage: platform darwin, python 3.10.6-final-0 ---------- =============================================================== short test summary info ================================================================ |
Signed-off-by: Suhail Rehman suhailrehman@gmail.com
What do these changes do?
Adds logs to each fuzzydata artifact generated to the pipeline. The artifact zip should contain a
run.log
file which details the exact sequence of operations and randomization parameters used in that fuzzydata run.flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
git commit -s
docs/development/architecture.rst
is up-to-date