Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-#5095: Remove release note checkbox from PR template #5096

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

noloerino
Copy link
Collaborator

@noloerino noloerino commented Oct 5, 2022

Signed-off-by: Jonathan Shi jhshi@ponder.io

What do these changes do?

  • commit message follows format outlined here
  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves DOCS: Remove release note checkbox from PR template #5095
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@noloerino noloerino requested a review from a team as a code owner October 5, 2022 23:53
mvashishtha
mvashishtha previously approved these changes Oct 5, 2022
@mvashishtha
Copy link
Collaborator

@modin-project/modin-contributors @modin-project/modin-core please take a look. I will merge this if no one else leaves a comment in 24 hours.

@noloerino noloerino changed the title REFACTOR-#5095: Remove release note checkbox from PR template DOCS-#5095: Remove release note checkbox from PR template Oct 5, 2022
Signed-off-by: Jonathan Shi <jhshi@ponder.io>
@noloerino
Copy link
Collaborator Author

(changed REFACTOR -> DOCS)

@YarShev YarShev merged commit d7cab02 into modin-project:master Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOCS: Remove release note checkbox from PR template
3 participants