REFACTOR-#5005: Use finalize method instead of list comprehension + drain_call_queue
#5006
Conversation
…l_queue Signed-off-by: Myachev <anatoly.myachev@intel.com>
Codecov Report
@@ Coverage Diff @@
## master #5006 +/- ##
==========================================
+ Coverage 84.89% 89.59% +4.70%
==========================================
Files 267 268 +1
Lines 19749 20031 +282
==========================================
+ Hits 16766 17947 +1181
+ Misses 2983 2084 -899
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Myachev <anatoly.myachev@intel.com>
| @@ -1316,7 +1316,6 @@ def get_right_block(right_partitions, row_idx, col_idx): | |||
| ) | |||
|
|
|||
| @classmethod | |||
| @wait_computations_if_benchmark_mode | |||
There was a problem hiding this comment.
There is no need to make this operation synchronous, we can make the operation that calls add_to_apply_calls function synchronous (thereby creating a queue for execution), for example: lazy_map_partitions.
There was a problem hiding this comment.
Also, this wrapping is incorrect because wait_computations_if_benchmark_mode assumes the function returns partitions. See also #4273.
There was a problem hiding this comment.
@mvashishtha will this fix #4273 as well? Should we add a test here and verify that it does resolve that issue?
There was a problem hiding this comment.
Yes, it fixes. We can add a test, but it is not necessary, as there are others that will break if we change the implementation.
Signed-off-by: Myachev anatoly.myachev@intel.com
What do these changes do?
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sfinalizemethod instead of list comprehension + drain_call_queue #5005docs/development/architecture.rstis up-to-date