Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PERF-#4890: PandasDataframeAxisPartition.drain should be serialized only once #4891

Merged
merged 4 commits into from
Aug 31, 2022

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Aug 29, 2022

Signed-off-by: Myachev anatoly.myachev@intel.com

What do these changes do?

  • commit message follows format outlined here
  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves PERF: drain function should be serialized only once #4890
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date
  • added (Issue Number: PR title (PR Number)) and github username to release notes for next major release

Signed-off-by: Myachev <anatoly.myachev@intel.com>
@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #4891 (7688e64) into master (636fc59) will increase coverage by 4.64%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4891      +/-   ##
==========================================
+ Coverage   85.17%   89.82%   +4.64%     
==========================================
  Files         265      266       +1     
  Lines       19645    19919     +274     
==========================================
+ Hits        16733    17892    +1159     
+ Misses       2912     2027     -885     
Impacted Files Coverage Δ
...s/pandas_on_dask/partitioning/virtual_partition.py 85.29% <ø> (-1.44%) ⬇️
...re/dataframe/pandas/partitioning/axis_partition.py 98.11% <100.00%> (+0.33%) ⬆️
...ns/pandas_on_ray/partitioning/virtual_partition.py 86.59% <100.00%> (+1.55%) ⬆️
modin/logging/config.py 94.59% <0.00%> (-1.30%) ⬇️
modin/core/execution/ray/generic/modin_aqp.py 23.40% <0.00%> (ø)
...lementations/pandas_on_dask/dataframe/dataframe.py 95.83% <0.00%> (ø)
...pandas_on_python/partitioning/virtual_partition.py 100.00% <0.00%> (ø)
modin/experimental/batch/test/test_pipeline.py 90.21% <0.00%> (ø)
... and 45 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Myachev <anatoly.myachev@intel.com>
Signed-off-by: Myachev <anatoly.myachev@intel.com>
Signed-off-by: Myachev <anatoly.myachev@intel.com>
@anmyachev anmyachev marked this pull request as ready for review August 29, 2022 19:20
@anmyachev anmyachev requested a review from a team as a code owner August 29, 2022 19:20
@YarShev YarShev merged commit bbfc571 into modin-project:master Aug 31, 2022
@anmyachev anmyachev deleted the issue4890 branch August 31, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PERF: drain function should be serialized only once
4 participants