Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the pandas dependency from BlockPartitions #437

Merged
merged 3 commits into from
Feb 2, 2019
Merged

Remove the pandas dependency from BlockPartitions #437

merged 3 commits into from
Feb 2, 2019

Conversation

devin-petersohn
Copy link
Collaborator

  • No longer need it beyond to_pandas
  • More general for other formats/backends
  • Move pandas dependency to pandas query compiler

What do these changes do?

Related issue number

N/A Code quality

  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • passes black --check modin/

@devin-petersohn
Remove the pandas dependency from BlockPartitions
016ebef 
* No longer need it beyond `to_pandas`
* More general for other formats/backends
* Move pandas dependency to pandas query compiler
@devin-petersohn
Lint
7059d30
@devin-petersohn
Lint
a6e806c
@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-Performance-PRB/318/
Test PASSed.

@AmplabJenkins
Copy link

Merged build finished. Test PASSed.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Modin-PRB/379/
Test PASSed.

@devin-petersohn devin-petersohn merged commit 3af4be9 into modin-project:master Feb 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devin-petersohn @AmplabJenkins