-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX-#4058: Allow pickling empty dataframes and series. #4095
FIX-#4058: Allow pickling empty dataframes and series. #4095
Conversation
Signed-off-by: mvashishtha <mahesh@ponder.io>
Codecov Report
@@ Coverage Diff @@
## master #4095 +/- ##
==========================================
+ Coverage 85.61% 88.62% +3.00%
==========================================
Files 201 201
Lines 16852 16852
==========================================
+ Hits 14428 14935 +507
+ Misses 2424 1917 -507
Continue to review full report at Codecov.
|
Signed-off-by: mvashishtha <mahesh@ponder.io>
Co-authored-by: Rehan Sohail Durrani <rdurrani@berkeley.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: mvashishtha mahesh@ponder.io
What do these changes do?
Allow pickling empty dataframes and series.
We need to implement
__reduce_ex__
forSeries
andDataframe
forpickle
to pickle them with their own__reduce__
methods instead of defaulting to pandas for__reduce_ex__
.flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
git commit -s
ray.cloudpickle
can't serialize empty Modin DataFrame #4058docs/development/architecture.rst
is up-to-date