Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REFACTOR: Fix and refactor resample methods #6069

Closed
noloerino opened this issue May 2, 2023 · 1 comment · Fixed by #6179
Closed

REFACTOR: Fix and refactor resample methods #6069

noloerino opened this issue May 2, 2023 · 1 comment · Fixed by #6179
Labels
Code Quality 💯 Improvements or issues to improve quality of codebase P2 Minor bugs or low-priority feature requests ponder modin work desired for the ponder product

Comments

@noloerino
Copy link
Collaborator

We need to port fixes for resample.{sum,prod,size} and route a few additional methods differently. Unfortunately, the commits do not include test cases, so we will need to either comb through our internal JIRA or triage the failure cases manually.
@noloerino noloerino added new feature/request 💬 Requests and pull requests for new features Triage 🩹 Issues that need triage Code Quality 💯 Improvements or issues to improve quality of codebase P2 Minor bugs or low-priority feature requests and removed new feature/request 💬 Requests and pull requests for new features Triage 🩹 Issues that need triage labels May 2, 2023
@mvashishtha mvashishtha added the ponder modin work desired for the ponder product label May 10, 2023
@mvashishtha
Copy link
Collaborator

I can't keep working on this right now but I started a branch with all the commits, but there are some test failures at least in test_resample: https://github.com/mvashishtha/modin/tree/6069/fix-up-resample

devin-petersohn pushed a commit to devin-petersohn/modin that referenced this issue May 21, 2023
@naren-ponder @devin-petersohn
FIX-modin-project#6069: Improve the way resample is handled at the AP…
60c0412 
…I layer

Signed-off-by: Naren Krishna <naren@ponder.io>
@devin-petersohn devin-petersohn mentioned this issue May 22, 2023
Merged
7 tasks
RehanSD pushed a commit that referenced this issue May 22, 2023
@devin-petersohn
FIX-#6069: Improve the way resample is handled at the API layer (#6179)
49ae34d 
Signed-off-by: Naren Krishna <naren@ponder.io>
Signed-off-by: Devin Petersohn <devin.petersohn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Code Quality 💯 Improvements or issues to improve quality of codebase P2 Minor bugs or low-priority feature requests ponder modin work desired for the ponder product
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FIX-#6069: Improve the way resample is handled at the API layer devin-petersohn/modin
2 participants
@mvashishtha @noloerino